-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[bsp][xuantie] Modernize Kconfig syntax for variable declarations #10930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: libcpu_riscvReviewers: @Yaochenger Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-11-13 13:43 CST)
📝 Review Instructions
|
8d3eaf8 to
27cfc6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the Kconfig syntax for the xuantie BSP family by migrating from the older config declaration style with option env to the newer variable assignment syntax using :=. This brings these BSPs in line with the standard Kconfig format used across other RT-Thread BSPs.
- Replaces deprecated
configdeclarations for BSP_DIR, RTT_DIR, and PKGS_DIR with direct variable assignments - Updates source statements from
"$RTT_DIR/Kconfig"to"$(RTT_DIR)/Kconfig"for consistency - Removes unused ENV_DIR configuration that is no longer needed
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bsp/xuantie/xiaohui/r920/Kconfig | Modernizes Kconfig variable declarations and source syntax for r920 board |
| bsp/xuantie/xiaohui/r910/Kconfig | Modernizes Kconfig variable declarations and source syntax for r910 board |
| bsp/xuantie/xiaohui/r908/Kconfig | Modernizes Kconfig variable declarations and source syntax for r908 board |
| bsp/xuantie/xiaohui/c910/Kconfig | Modernizes Kconfig variable declarations and source syntax for c910 board |
| bsp/xuantie/xiaohui/c908/Kconfig | Modernizes Kconfig variable declarations and source syntax for c908 board |
| bsp/xuantie/xiaohui/c907/Kconfig | Modernizes Kconfig variable declarations and source syntax for c907 board |
| bsp/xuantie/xiaohui/c906/Kconfig | Modernizes Kconfig variable declarations and source syntax for c906 board |
| bsp/xuantie/smartl/e907/Kconfig | Modernizes Kconfig variable declarations and source syntax for e907 board |
| bsp/xuantie/smartl/e906/Kconfig | Modernizes Kconfig variable declarations and source syntax for e906 board |
| bsp/xuantie/smartl/e902/Kconfig | Modernizes Kconfig variable declarations and source syntax for e902 board |
| @@ -1,27 +1,10 @@ | |||
| mainmenu "RT-Thread Configuration" | |||
Copilot
AI
Nov 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Title Naming / PR 标题命名
English: The PR title should be more specific and use English for better international readability. According to RT-Thread guidelines, the title should clearly describe what is being fixed. Consider a title like:
[xuantie] Modernize Kconfig syntax for variable declarations
or
[xuantie] Update Kconfig to use variable assignment syntax
中文:PR 标题应该更具体,并使用英文以提高国际可读性。根据 RT-Thread 指南,标题应清楚描述修复的内容。建议使用如下标题:
[xuantie] Modernize Kconfig syntax for variable declarations
或
[xuantie] Update Kconfig to use variable assignment syntax
The current title "修正BSP根路径Kconfig脚本" is somewhat vague about what specifically is being corrected.
拉取/合并请求描述:(PR description)
为什么提交这份PR (why to submit this PR)
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up