Skip to content

🐞 fix(at_socket):修复socket 在开启server下的connect连接 #10967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 1 commit into from
Nov 21, 2025
Merged

🐞 fix(at_socket):修复socket 在开启server下的connect连接 #10967

Rbb666 merged 1 commit into from
Nov 21, 2025

Conversation

@meng-plus
Copy link
Contributor

@meng-plus meng-plus commented Nov 21, 2025

修复accept在错误执行过程中返回无效socket问题

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

🐞 fix(at_socket):修复socket 在开启server下的connect连接
修复accept在错误执行过程中返回无效socket问题

你的解决方案是什么 (what is your solution)

1.创建socket connect时已经创建了 连接成功指示时应当先检查是否存在
2. 当异常执行时 accept 返回的空指针指向的socket为无效数值，应返回<0的数值
在esp32下测试通过

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@meng-plus
🐞 fix(at_socket):修复socket 在开启server下的connect连接
5f72984 
修复accept在错误执行过程中返回无效socket问题
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：fix/socket
  • 设置PR number为 \ Set the PR number to：10967
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 fix/socket 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/socket branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/net/at/at_socket/at_socket.c

🏷️ Tag: components_net_at

Reviewers: @Ryan-CW-Code @lizhen9880

Changed Files (Click to expand)
  • components/net/at/at_socket/at_socket.c

📊 Current Review Status (Last Updated: 2025-11-21 11:25 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Ryan-CW-Code
Ryan-CW-Code reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@Ryan-CW-Code Ryan-CW-Code left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们用了3年at_socket的经验，建议at设备上网：
4g模组就用lwip+ppp实现，lwip 2.2.1的PPP很稳，现在at_client也可以deinit了，获取csq等at命令也很方便
wifi模组就想办法对接RTT的wlan框架，RTT的rw007，乐鑫的esp系列都可以对接

components/net/at/at_socket/at_socket.c
char *socket_info = RT_NULL;
int base_socket = 0;

rt_sscanf(buff, "SOCKET:%d", &base_socket);
Copy link
Contributor

@Ryan-CW-Code Ryan-CW-Code Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接读取缓冲区是没法兼容很多AT设备的

Copy link
Contributor Author

@meng-plus meng-plus Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我只是把下面的 往前提了一下 ，您说的应该是当前组件的问题 ，不是我新引入的问题

Copy link
Contributor

@Ryan-CW-Code Ryan-CW-Code Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦哦，那应该没什么问题。 我看目前也就esp适配了at_server接口，可以先合并进去。

@Rbb666 Rbb666 merged commit 6ab057b into RT-Thread:master Nov 21, 2025
56 checks passed
@meng-plus meng-plus deleted the fix/socket branch November 22, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

+1 more reviewer

@Ryan-CW-Code Ryan-CW-Code Ryan-CW-Code left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component: net/at component: net Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meng-plus @Rbb666 @Ryan-CW-Code