Skip to content

[bsp][renesas] Add ra8p1-titan-board BSP #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 2 commits into from
Dec 3, 2025
Merged

[bsp][renesas] Add ra8p1-titan-board BSP #11000

Rbb666 merged 2 commits into from
Dec 3, 2025

Conversation

@yans6666
Copy link
Contributor

@yans6666 yans6666 commented Dec 1, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

添加 ra8p1-titan-board BSP 到主线

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：add_titan_bsp
  • 设置PR number为 \ Set the PR number to：11000
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 add_titan_bsp 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the add_titan_bsp branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: kurisaW

Changed Files (Click to expand)
  • bsp/renesas/README.md
  • bsp/renesas/libraries/HAL_Drivers/drivers/SConscript
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/drv_config.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/ra8/adc_config.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/ra8/canfd_config.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/ra8/pwm_config.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/ra8/timer_config.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_adc.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_can.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_dac.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_eth.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_eth.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_gpio.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_hwtimer.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_lcd.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_pwm.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_rs485.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_rs485.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_sci.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_sdhi.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_sdhi.h
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_spi.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_usart_v2.c
  • bsp/renesas/libraries/HAL_Drivers/drv_common.c
  • bsp/renesas/libraries/Kconfig
  • bsp/renesas/ra8p1-titan-board/.ci/attachconfig/attachconfig.yml
  • bsp/renesas/ra8p1-titan-board/.config
  • bsp/renesas/ra8p1-titan-board/.cproject

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-12-03 10:23 CST)

  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review
  • ⌛ supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP action github action yml imporve BSP: Renesas BSP related with Renesas labels Dec 1, 2025
@Rbb666 Rbb666 requested a review from Copilot December 1, 2025 11:06
Copilot AI reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds BSP support for the Renesas RA8P1 Titan Board to RT-Thread, including LVGL integration with Arm-2D acceleration library for enhanced graphics performance.

Reviewed changes

Copilot reviewed 74 out of 602 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Source/*.inc Arm-2D library C template files for tile operations with masking and mirroring
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Source/*.c Arm-2D implementation files for color conversion and filling operations
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/*.h Arm-2D header files including configuration, utilities, and architecture port
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/SConscript Build script for Arm-2D library integration
bsp/renesas/ra8p1-titan-board/board/lvgl/SConscript Main LVGL build script

...as/ra8p1-titan-board/board/lvgl/arm-2d/Source/__arm_2d_copy_with_mask_and_mirror_wrapper.inc Outdated
#include "__arm_2d_meta_fill_with_des_mask_and_mirror.inc"

/*----------------------------------------------------------------------------*
* fill with x-miorro *
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'

Suggested change
* fill with x-miorro *
* fill with x-mirror *

Copilot uses AI. Check for mistakes.
...as/ra8p1-titan-board/board/lvgl/arm-2d/Source/__arm_2d_copy_with_mask_and_mirror_wrapper.inc Outdated
#include "__arm_2d_meta_fill_with_des_mask_and_mirror.inc"

/*----------------------------------------------------------------------------*
* fill with y-miorro *
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'

Suggested change
* fill with y-miorro *
* fill with y-mirror *

Copilot uses AI. Check for mistakes.
...as/ra8p1-titan-board/board/lvgl/arm-2d/Source/__arm_2d_copy_with_mask_and_mirror_wrapper.inc Outdated
#include "__arm_2d_meta_fill_with_des_mask_and_mirror.inc"

/*----------------------------------------------------------------------------*
* fill with xy-miorro *
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'

Copilot uses AI. Check for mistakes.
...titan-board/board/lvgl/arm-2d/Source/__arm_2d_copy_with_colour_keying_and_mirror_wrapper.inc Outdated


/*----------------------------------------------------------------------------*
* fill with x-miorro *
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'

Copilot uses AI. Check for mistakes.
...titan-board/board/lvgl/arm-2d/Source/__arm_2d_copy_with_colour_keying_and_mirror_wrapper.inc Outdated


/*----------------------------------------------------------------------------*
* fill with y-miorro *
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'

Copilot uses AI. Check for mistakes.
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/template/arm_2d_cfg.h Outdated
# define __ARM_2D_HAS_ASYNC__ 0
#endif

// <q>Enable anti-alias support for all tranform operations.
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'tranform' to 'transform' / 将 'tranform' 拼写更正为 'transform'

Suggested change
// <q>Enable anti-alias support for all tranform operations.
// <q>Enable anti-alias support for all transform operations.

Copilot uses AI. Check for mistakes.
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/template/arm_2d_cfg.h Outdated
//#define __ARM_2D_CFG_UNSAFE_IGNORE_ALPHA_255_COMPENSATION__
// </c>

// <c1> Ignore calibrartion for small angles in transform operations
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'calibrartion' to 'calibration' / 将 'calibrartion' 拼写更正为 'calibration'

Suggested change
// <c1> Ignore calibrartion for small angles in transform operations
// <c1> Ignore calibration for small angles in transform operations

Copilot uses AI. Check for mistakes.
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/arm_2d_utils.h Outdated
#undef ARM_2D_PARAM

/*!
* \brief a macro helper to be used with ARM_2D_INVODE to improve the
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'INVODE' to 'INVOKE' / 将 'INVODE' 拼写更正为 'INVOKE'

Suggested change
* \brief a macro helper to be used with ARM_2D_INVODE to improve the
* \brief a macro helper to be used with ARM_2D_INVOKE to improve the

Copilot uses AI. Check for mistakes.
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/arm_2d_utils.h Outdated

#ifndef ARM_2D_INVOKE
/*!
* \brief A macro to safely invode a function pointer
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'invode' to 'invoke' / 将 'invode' 拼写更正为 'invoke'

Suggested change
* \brief A macro to safely invode a function pointer
* \brief A macro to safely invoke a function pointer

Copilot uses AI. Check for mistakes.
bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/arm_2d_utils.h Outdated
#define __ARM_ALIGN(__N) __attribute__((aligned(__N)))

/*!
* \brief an attribute to specify aligment requirement
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'aligment' to 'alignment' / 将 'aligment' 拼写更正为 'alignment'

Suggested change
* \brief an attribute to specify aligment requirement
* \brief an attribute to specify alignment requirement

Copilot uses AI. Check for mistakes.
@supperthomas
Copy link
Member

supperthomas commented Dec 1, 2025

/board/lvgl/ LVGL请用软件包

@yans6666 yans6666 marked this pull request as draft December 2, 2025 01:12
@yans6666 yans6666 force-pushed the add_titan_bsp branch 3 times, most recently from 5c86ff7 to 1c4fe91 Compare December 2, 2025 07:25
@yans6666 yans6666 marked this pull request as ready for review December 2, 2025 07:50
@supperthomas
Copy link
Member

supperthomas commented Dec 2, 2025

📄 bsp/renesas/ra8p1-titan-board/figures/big.png — [A]
📦 Size: 640.1 KB

图片压缩一下

@supperthomas
Copy link
Member

supperthomas commented Dec 2, 2025

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm23.h — [A]
📦 Size: 111.9 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm3.h — [A]
📦 Size: 111.0 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm33.h — [A]
📦 Size: 176.7 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm35p.h — [A]
📦 Size: 176.8 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm4.h — [A]
📦 Size: 122.3 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm52.h — [A]
📦 Size: 306.5 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm55.h — [A]
📦 Size: 311.5 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm7.h — [A]
📦 Size: 139.4 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm85.h — [A]
📦 Size: 314.8 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_sc000.h — [A]
📦 Size: 45.9 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_sc300.h — [A]
📦 Size: 110.0 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_starmc1.h — [A]
📦 Size: 189.1 KB

@Rbb666 瑞萨这块代码CMSIS_6这些编译不到，而且越来越大。建议整合到软件包里面

@Rbb666
Copy link
Member

Rbb666 commented Dec 3, 2025

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm23.h — [A] 📦 Size: 111.9 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm3.h — [A] 📦 Size: 111.0 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm33.h — [A] 📦 Size: 176.7 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm35p.h — [A] 📦 Size: 176.8 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm4.h — [A] 📦 Size: 122.3 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm52.h — [A] 📦 Size: 306.5 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm55.h — [A] 📦 Size: 311.5 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm7.h — [A] 📦 Size: 139.4 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_cm85.h — [A] 📦 Size: 314.8 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_sc000.h — [A] 📦 Size: 45.9 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_sc300.h — [A] 📦 Size: 110.0 KB

📄 bsp/renesas/ra8p1-titan-board/ra/arm/CMSIS_6/CMSIS/Core/Include/core_starmc1.h — [A] 📦 Size: 189.1 KB

@Rbb666 瑞萨这块代码CMSIS_6这些编译不到，而且越来越大。建议整合到软件包里面

瑞萨的比较特殊，我感觉拆出去不太好，如果换了fsp版本生成的内容都不一样吧

@yans6666
Copy link
Contributor Author

yans6666 commented Dec 3, 2025 •
edited
Loading

📄 bsp/renesas/ra8p1-titan-board/figures/big.png — [A] 📦 Size: 640.1 KB

图片压缩一下

已经压缩到60KB了

@supperthomas
Copy link
Member

supperthomas commented Dec 3, 2025

应该是可以的，可以参考cubemx一样，FSP工具可以生成一些配置信息，然后FSP版本由软件包固定，sconsscript指向到软件包中。定期可以更新FSP大版本。FSP都是一样的。参考仓库：https://github.com/renesas/fsp， 当然你们也可以选择每个系列一种FSP。

@Rbb666
Copy link
Member

Rbb666 commented Dec 3, 2025

应该是可以的，可以参考cubemx一样，FSP工具可以生成一些配置信息，然后FSP版本由软件包固定，sconsscript指向到软件包中。定期可以更新FSP大版本。FSP都是一样的。参考仓库：https://github.com/renesas/fsp， 当然你们也可以选择每个系列一种FSP。

应该是可以的，可以参考cubemx一样，FSP工具可以生成一些配置信息，然后FSP版本由软件包固定，sconsscript指向到软件包中。定期可以更新FSP大版本。FSP都是一样的。参考仓库：https://github.com/renesas/fsp， 当然你们也可以选择每个系列一种FSP。

我建议先合并进去，后面讨论下如何更合理的拆分下瑞萨的驱动库

@Rbb666 Rbb666 merged commit 0ea9d8f into RT-Thread:master Dec 3, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Rbb666 Rbb666 Rbb666 approved these changes

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

Assignees

No one assigned

Labels

action github action yml imporve BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yans6666 @supperthomas @Rbb666