Skip to content

Conversation

@GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Dec 9, 2025

拉取/合并请求描述:(PR description)

[

  1. Add power event.
  2. Port to touch.
  3. Add uapi for unix app.
  4. Add NI Ettus Research USRP E3xx Button support.
  5. Add GPIO Keyboards support.

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:input
  • 设置PR number为 \ Set the PR number to:11031
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 input 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the input branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/drivers/Kconfig
  • components/drivers/include/dt-bindings/input/event-codes.h
  • components/drivers/include/rtdevice.h
  • components/drivers/input/Kconfig
  • components/drivers/input/SConscript
  • components/drivers/input/input.c
  • components/drivers/input/input_power.c
  • components/drivers/input/input_touch.c
  • components/drivers/input/input_uapi.c
  • components/drivers/input/joystick/Kconfig
  • components/drivers/input/joystick/SConscript
  • components/drivers/input/keyboard/Kconfig
  • components/drivers/input/keyboard/SConscript
  • components/drivers/input/keyboard/keys-gpio.c
  • components/drivers/input/misc/Kconfig
  • components/drivers/input/misc/SConscript
  • components/drivers/input/misc/button-e3x0.c
  • components/drivers/input/touchscreen/Kconfig
  • components/drivers/input/touchscreen/SConscript

📊 Current Review Status (Last Updated: 2025-12-10 11:58 CST)

  • Maihuanyi Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a comprehensive input device framework to RT-Thread, introducing support for various input devices including keyboards, touchscreens, joysticks, and miscellaneous input devices. The implementation includes power event handling, touch device abstraction layer, Unix-style API (UAPI) for application compatibility, and hardware-specific drivers.

Key Changes

  • Added core input device framework with event handling, capability management, and handler registration system
  • Implemented touch device abstraction with multi-touch support and coordinate transformation
  • Integrated Unix-style API (UAPI) for file operations (open, close, read, write, ioctl, poll)
  • Added power event handling for system shutdown/restart via input events
  • Included hardware drivers for GPIO keyboards and NI Ettus Research USRP E3x0 buttons

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
components/drivers/input/input.c Core input device registration, capability management, and event dispatch system
components/drivers/input/input_power.c Power event handler for system shutdown/restart via KEY_POWER and KEY_RESTART
components/drivers/input/input_touch.c Touch device abstraction layer with coordinate transformation and multi-touch support
components/drivers/input/input_uapi.c Unix API implementation providing file operations for input devices
components/drivers/input/keyboard/keys-gpio.c GPIO-based keyboard driver supporting device tree configuration
components/drivers/input/misc/button-e3x0.c Hardware-specific button driver for NI Ettus E3x0 platform
components/drivers/input/touchscreen/Kconfig Configuration for touchscreen device drivers
components/drivers/input/joystick/Kconfig Configuration for joystick device drivers
components/drivers/input/misc/Kconfig Configuration for miscellaneous input devices
components/drivers/input/keyboard/Kconfig Configuration for keyboard device drivers
components/drivers/input/Kconfig Main input subsystem configuration
components/drivers/input/SConscript Build script for input subsystem
components/drivers/include/dt-bindings/input/event-codes.h Standard Linux-compatible input event code definitions
components/drivers/include/rtdevice.h Integration of input headers into RT-Thread device framework
components/drivers/Kconfig Added input subsystem to drivers configuration

For: RT-Thread#6251

1. Add power event.
2. Port to touch.
3. Add uapi for unix app.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
1. NI Ettus Research USRP E3xx Button support.
2. GPIO Keyboards support.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
Copy link
Contributor Author

@Rbb666 AI 相关合理问题已修改

@Rbb666 Rbb666 merged commit 3ff3fc3 into RT-Thread:master Dec 10, 2025
58 checks passed
Dailingxiang1 pushed a commit to Dailingxiang1/rt-thread that referenced this pull request Dec 11, 2025
@GuEe-GUI GuEe-GUI deleted the input branch December 12, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants