[dm][rtc] update rtc and new drivers #11033

GuEe-GUI · 2025-12-09T12:43:25Z

拉取/合并请求描述：(PR description)

[

set the RTC alarm thread stack size default.
make Kconfig import for DM.
add DM API: rtc_dev_set_name for RTC device init the name auto.
add DM API: rtc_wkalarm_to_timestamp and rtc_timestamp_to_wkalarm for rt_rtc_wkalarm/time_t convert.
add new drivers:
- Dallas/Maxim DS1302
- Dallas/Maxim DS1307/37/38/39/40, ST M41T11
- Goldfish Real Time Clock
- Haoyu Microelectronics HYM8563
- NXP PCF8523
- Philips PCF8563/Epson RTC8564
- ARM PL031
- Epson RX8010SJ

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Signed-off-by: GuEe-GUI <2991707448@qq.com>

1. rtc_dev_set_name for RTC device init the name auto. 2. rtc_wkalarm_to_timestamp and rtc_timestamp_to_wkalarm for rt_rtc_wkalarm/time_t convert. Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions · 2025-12-09T12:43:33Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：rtc
设置PR number为 \ Set the PR number to：11033

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 rtc 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the rtc branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-12-09T12:43:38Z

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)

components/drivers/rtc/Kconfig
components/drivers/rtc/SConscript
components/drivers/rtc/rtc-ds1302.c
components/drivers/rtc/rtc-ds1307.c
components/drivers/rtc/rtc-goldfish.c
components/drivers/rtc/rtc-hym8563.c
components/drivers/rtc/rtc-pcf8523.c
components/drivers/rtc/rtc-pcf8563.c
components/drivers/rtc/rtc-pl031.c
components/drivers/rtc/rtc-rx8010.c
components/drivers/rtc/rtc_dm.c
components/drivers/rtc/rtc_dm.h

📊 Current Review Status (Last Updated: 2025-12-10 11:17 CST)

⌛ Maihuanyi Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Copilot

Pull request overview

This PR adds Device Manager (DM) support and multiple new RTC drivers to RT-Thread, including DS1302, DS1307, Goldfish, HYM8563, PCF8523, PCF8563, PL031, and RX8010.

Key Changes:

New DM helper API for RTC device naming and alarm conversion (rtc_dm.c, rtc_dm.h)
Eight new RTC device drivers with I2C/SPI/MMIO interfaces
Updated Kconfig to change alarm thread stack size default from 2048 to IDLE_THREAD_STACK_SIZE

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
components/drivers/rtc/rtc_dm.h	Declares DM helper functions for RTC device naming and alarm/timestamp conversion
components/drivers/rtc/rtc_dm.c	Implements automatic RTC device naming and alarm conversion utilities
components/drivers/rtc/rtc-rx8010.c	Driver for Epson RX8010SJ I2C RTC with alarm support - has duplicate bit operation bug
components/drivers/rtc/rtc-pl031.c	Driver for ARM PL031 MMIO RTC - has pointer cast bug
components/drivers/rtc/rtc-pcf8563.c	Driver for Philips PCF8563/Epson RTC8564 I2C RTC with clock output
components/drivers/rtc/rtc-pcf8523.c	Driver for NXP PCF8523 I2C RTC
components/drivers/rtc/rtc-hym8563.c	Driver for Haoyu HYM8563 I2C RTC with clock output - has typo in error message
components/drivers/rtc/rtc-goldfish.c	Driver for Goldfish (Android emulator) RTC
components/drivers/rtc/rtc-ds1307.c	Driver for Dallas DS1307 family I2C RTCs
components/drivers/rtc/rtc-ds1302.c	Driver for Dallas DS1302 SPI RTC
components/drivers/rtc/SConscript	Build script updates to include new drivers based on Kconfig
components/drivers/rtc/Kconfig	Configuration options for new drivers - has wrong dependency for DS1307

components/drivers/rtc/rtc-hym8563.c

components/drivers/rtc/Kconfig

components/drivers/rtc/rtc-rx8010.c

components/drivers/rtc/rtc-hym8563.c

components/drivers/rtc/rtc-rx8010.c

components/drivers/rtc/rtc-pl031.c

components/drivers/rtc/rtc-pcf8563.c

1. Dallas/Maxim DS1302 2. Dallas/Maxim DS1307/37/38/39/40, ST M41T11 3. Goldfish Real Time Clock 4. Haoyu Microelectronics HYM8563 5. NXP PCF8523 6. Philips PCF8563/Epson RTC8564 7. ARM PL031 8. Epson RX8010SJ Signed-off-by: GuEe-GUI <2991707448@qq.com>

GuEe-GUI · 2025-12-10T03:17:22Z

@Rbb666 AI 相关要求已修改

* [dd][rtc] set the RTC alarm thread stack size default. Signed-off-by: GuEe-GUI <2991707448@qq.com> * [dm][rtc] make Kconfig import for DM Signed-off-by: GuEe-GUI <2991707448@qq.com> * [dm][rtc] support DM API for RTC 1. rtc_dev_set_name for RTC device init the name auto. 2. rtc_wkalarm_to_timestamp and rtc_timestamp_to_wkalarm for rt_rtc_wkalarm/time_t convert. Signed-off-by: GuEe-GUI <2991707448@qq.com> * [dm][rtc] add new drivers 1. Dallas/Maxim DS1302 2. Dallas/Maxim DS1307/37/38/39/40, ST M41T11 3. Goldfish Real Time Clock 4. Haoyu Microelectronics HYM8563 5. NXP PCF8523 6. Philips PCF8563/Epson RTC8564 7. ARM PL031 8. Epson RX8010SJ Signed-off-by: GuEe-GUI <2991707448@qq.com> --------- Signed-off-by: GuEe-GUI <2991707448@qq.com>

GuEe-GUI added 3 commits December 9, 2025 20:40

[dd][rtc] set the RTC alarm thread stack size default.

2fc6d1b

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[dm][rtc] make Kconfig import for DM

46bfd4d

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[dm][rtc] support DM API for RTC

a083fb9

1. rtc_dev_set_name for RTC device init the name auto. 2. rtc_wkalarm_to_timestamp and rtc_timestamp_to_wkalarm for rt_rtc_wkalarm/time_t convert. Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions bot added Component component: drivers/rtc component: drivers labels Dec 9, 2025

Rbb666 requested a review from Copilot December 9, 2025 13:06

Copilot started reviewing on behalf of Rbb666 December 9, 2025 13:07 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

[dm][rtc] add new drivers

bf053c1

1. Dallas/Maxim DS1302 2. Dallas/Maxim DS1307/37/38/39/40, ST M41T11 3. Goldfish Real Time Clock 4. Haoyu Microelectronics HYM8563 5. NXP PCF8523 6. Philips PCF8563/Epson RTC8564 7. ARM PL031 8. Epson RX8010SJ Signed-off-by: GuEe-GUI <2991707448@qq.com>

GuEe-GUI force-pushed the rtc branch from 093b47e to bf053c1 Compare December 10, 2025 03:17

Rbb666 approved these changes Dec 10, 2025

View reviewed changes

Rbb666 merged commit e465ec5 into RT-Thread:master Dec 10, 2025
58 checks passed

GuEe-GUI deleted the rtc branch December 12, 2025 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dm][rtc] update rtc and new drivers #11033

[dm][rtc] update rtc and new drivers #11033

Uh oh!

GuEe-GUI commented Dec 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuEe-GUI commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[dm][rtc] update rtc and new drivers #11033

[dm][rtc] update rtc and new drivers #11033

Uh oh!

Conversation

GuEe-GUI commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Dec 9, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: components

📊 Current Review Status (Last Updated: 2025-12-10 11:17 CST)

📝 Review Instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuEe-GUI commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GuEe-GUI commented Dec 9, 2025 •

edited

Loading

github-actions bot commented Dec 9, 2025 •

edited

Loading