-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[dm][firmware][scmi] support ARM-SCMI interface #11069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_driver_pmReviewers: wdfk-prog Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-18 12:32 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive ARM System Control and Management Interface (SCMI) protocol support to RT-Thread, enabling communication between application processors and system control processors for managing clocks, resets, power domains, regulators, pin control, and thermal sensors.
Key Changes
- Implements ARM-SCMI firmware infrastructure with mailbox and SMC transport layers
- Adds 6 SCMI protocol drivers (clock, reset, regulator, power domain, pinctrl, thermal)
- Provides comprehensive SCMI protocol definitions and message structures
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| components/drivers/include/drivers/scmi.h | Main SCMI header with protocol definitions and structures |
| components/drivers/firmware/arm_scmi/* | Core SCMI agent, bus, shared memory, and transport implementations |
| components/drivers/clk/clk-scmi.c | Clock control via SCMI protocol |
| components/drivers/reset/reset-scmi.c | Reset controller via SCMI |
| components/drivers/regulator/regulator-scmi.c | Voltage regulator control via SCMI |
| components/drivers/pmdomain/pm-domain-scmi.c | Power domain management via SCMI |
| components/drivers/pinctrl/pinctrl-scmi.c | Pin control configuration via SCMI |
| components/drivers/thermal/thermal-scmi.c | Thermal sensor reading via SCMI |
| components/drivers/*/Kconfig | Configuration options for SCMI drivers |
| components/drivers/*/SConscript | Build scripts for SCMI components |
Signed-off-by: GuEe-GUI <2991707448@qq.com>
1. Clock driver controlled via SCMI interface 2. Pinctrl driver via ARM SCMI interface 3. Power domain ARM SCMI 4. SCMI regulator 5. Reset driver controlled via ARM SCMI interface 6. Thermal Sensors Drivers Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
@Rbb666 AI 相关要求已修改 |
拉取/合并请求描述:(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up