Skip to content

Conversation

@Dailingxiang1
Copy link
Contributor

@Dailingxiang1 Dailingxiang1 commented Dec 24, 2025

拉取/合并请求描述:(PR description)

[

ecb6a2622b4e3fbc45a46b32b1629aca

为什么提交这份PR (why to submit this PR)

添加SDIO支持

你的解决方案是什么 (what is your solution)

添加SDIO支持

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/stm32/stm32f407-micu

  • .config:
    使能DFS里面的elm文件系统格式

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:bsp-stm32f407-micu-sdio
  • 设置PR number为 \ Set the PR number to:11081
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 bsp-stm32f407-micu-sdio 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the bsp-stm32f407-micu-sdio branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Dec 24, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
  • bsp/stm32/stm32f407-micu/board/Kconfig

🏷️ Tag: bsp_stm32f407-micu

Reviewers: Dailingxiang1

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
  • bsp/stm32/stm32f407-micu/board/Kconfig

📊 Current Review Status (Last Updated: 2025-12-24 14:17 CST)

  • Dailingxiang1 Pending Review
  • Liang1795 Pending Review
  • hamburger-os Pending Review
  • wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@supperthomas
Copy link
Member

这个是用ioc生成的吗?可以更新一下ioc

@Dailingxiang1
Copy link
Contributor Author

这个是用ioc生成的吗?可以更新一下ioc
没有用ioc生成了,直接修改hal_msp和hal_conf文件了

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds SDIO (Secure Digital Input/Output) support to the STM32F407-MICU BSP, enabling SD card functionality for the board. The changes configure the SDIO peripheral with appropriate GPIO pins (PC8-PC12 for data/clock, PD2 for command) and add Kconfig options for enabling SDIO with configurable maximum frequency.

Key changes:

  • Added Kconfig configuration for SDIO with configurable maximum frequency (default 1MHz, range 0-24MHz)
  • Implemented HAL MSP initialization and deinitialization functions for SDIO peripheral
  • Enabled HAL SD module support in HAL configuration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
bsp/stm32/stm32f407-micu/board/Kconfig Added BSP_USING_SDIO configuration option with SDIO_MAX_FREQ parameter for configurable SD card clock frequency
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c Added HAL_SD_MspInit and HAL_SD_MspDeInit functions to configure SDIO GPIO pins (PC8-12, PD2) and peripheral clocks
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h Enabled HAL_SD_MODULE_ENABLED macro to include SD card HAL driver support

config BSP_USING_SDIO
bool "Enable SDIO"
select RT_USING_SDIO
default n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config BSP_USING_SDIO
    bool "Enable SDIO"
    select RT_USING_SDIO
    default n
    if BSP_USING_SDIO
        config SDIO_MAX_FREQ
            int "sdio max freq"
            range 0 24000000
            depends on BSP_USING_SDIO
            default 1000000
    endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按这个修改吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外压缩一下提交

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按要求修改了

Update bsp/stm32/stm32f407-micu/board/Kconfig

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/board/Kconfig
@Dailingxiang1 Dailingxiang1 force-pushed the bsp-stm32f407-micu-sdio branch from 848a9a1 to 9e7f6d3 Compare December 24, 2025 06:17
@kurisaW kurisaW merged commit f52fb60 into RT-Thread:master Dec 24, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants