-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat[nxp][can]:add mcxa346 can device #11082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_mcxaReviewers: @hywing Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-24 13:30 CST)
📝 Review Instructions
|
| PORT_SetPinConfig(PORT3, 28U, &port3_28_pin73_config); | ||
|
|
||
|
|
||
| const port_pin_config_t port1_0_pin135_config = {/* Internal pull-up/down resistor is disabled */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段配置的删除会不会对SPI外设使能有所影响
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段配置的删除会不会对SPI外设使能有所影响
我看kconfig中也没有spi0的配置我就全删掉了,如果要保留的话得注意引脚会有冲突
|
@CYFS3 有时间的话可以帮忙看下nxp smart ci报错的原因吗,可以在linux下拉一下工具链然后本地测试看看是不是缺少依赖项使能 |
好的 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
测试用例
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up