Skip to content

Conversation

@unicornx
Copy link
Contributor

We often get wrong report when documentation related are changed, such as:

Getting action download info
Error: This request has been automatically failed because
it uses a deprecated version of `actions/download-artifact: v3`.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/.
This request has been automatically failed because it uses
a deprecated version of `actions/upload-artifact: v3`.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Just remove this action till now.

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

We often get wrong report when documentation related are
changed, such as:

```
Getting action download info
Error: This request has been automatically failed because
it uses a deprecated version of `actions/download-artifact: v3`.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/.
This request has been automatically failed because it uses
a deprecated version of `actions/upload-artifact: v3`.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
```

Just remove this action till now.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@unicornx unicornx requested a review from Rbb666 February 10, 2025 09:10
@github-actions github-actions bot added the action github action yml imporve label Feb 10, 2025
@Rbb666 Rbb666 merged commit 4edfa48 into RT-Thread:master Feb 10, 2025
46 checks passed
@supperthomas
Copy link
Member

@unicornx 汪老师,这个Check Spelling,偶尔帮忙测一下文档中的拼写错误,是不是可能还是有点帮助的?

@unicornx
Copy link
Contributor Author

@unicornx 汪老师,这个Check Spelling,偶尔帮忙测一下文档中的拼写错误,是不是可能还是有点帮助的?

报错显示这个 check 根本运行不起来,每次触发只会报错。所以和 @Rbb666 讨论后决定直接删除算了,除非以后有人愿意研究清楚怎么用起来。
image

@unicornx unicornx deleted the dev-remove-spell-check branch February 12, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants