Skip to content

[Kernel|DM] Rename and clean some code #9987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 7 commits into from
Feb 11, 2025
Merged

[Kernel|DM] Rename and clean some code #9987

Rbb666 merged 7 commits into from
Feb 11, 2025

Conversation

@GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Feb 11, 2025 •
edited
Loading

[

  1. Update kernel's boot link for ARM64.
  2. Add IDA init in runtime.
  3. Reset the value of PIN_NONE.
  4. Remove warning for ISO9660 ops.
  5. Replace spinlock static init by RT_DEFINE_SPINLOCK.
  6. Rename LED register/unregister.

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@GuEe-GUI
[AARCH64] Update kernel's boot link for ARM64
ceb37e7 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[DM/CORE] Add IDA init in runtime
c189222 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[DM/PIN] Reset the value of PIN_NONE
546a251 
PIN_NONE is '-1', is similar to '-RT_ERROR',
'-RT_EEMPTY' is better.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[DFS/ISO9660] Remove warning for ops
c448870 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[DM] Replace spinlock static init by RT_DEFINE_SPINLOCK
da65640 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[DM/LED] Rename LED register/unregister
614d6c0 
rt_hw_* is use for DM and not DM, but LED only use in DM.

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[DM/THERMAL] Remove unused code in update poll
dad2f3b 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI GuEe-GUI changed the title [Kernel|DM] Rename some symbol [Kernel|DM] Rename and clean some code Feb 11, 2025
@Rbb666 Rbb666 merged commit 74f43ed into RT-Thread:master Feb 11, 2025
47 of 48 checks passed
@GuEe-GUI GuEe-GUI deleted the dm_update branch February 20, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

Assignees

No one assigned

Labels

Arch: ARM/AArch64 BSP related with arm component: drivers/clk component: drivers/core component: drivers/ofw component: drivers/pci component: drivers/pic component: drivers Component libcpu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuEe-GUI @Rbb666