Skip to content

Conversation

@FWuellhorst
Copy link
Collaborator

@FWuellhorst FWuellhorst commented Jul 9, 2025

This closes #50.

Todos:

  • Check correctnes
  • Add test
  • add epw output and possibly others

Copy link
Contributor

@MartinRaetz MartinRaetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @FWuellhorst.

Can you confirm that the tests will cover sufficiently the new feature? Since its the new default the regression tests should be running on the new default.

@MartinRaetz MartinRaetz changed the base branch from main to development July 11, 2025 12:43
@FWuellhorst
Copy link
Collaborator Author

@MartinRaetz: I checked locally in Dymola for a single test and the feature works well for Modelica.

@TobiasSpratte : Can you check the with E+ if the exported .epw with the timezone also works as expected, especially in combination with SPAWN and mos. I don't know how to access the weather results from E+ in Spawn.

Future development options:

  • Add a simple test model to at least check created mos files locally for different tilts and orientations, see screenshot
image
  • Make all tests check both utc and export with timezone
  • add an example with a different timezone (e.g. -6) to trigger edge cases for large shifting

What do you think @MartinRaetz ? I would do that in other issues to keep this one focused on the timezone aspect.

@TobiasSpratte
Copy link
Contributor

I have checked the exported .mos and .epw files in EnergyPlus, Spawn and Modelica and everything works as expected. Thank you @FWuellhorst !

Copy link
Contributor

@MartinRaetz MartinRaetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this major PR! I think its a very helpful modification to meet the users expectations!

@FWuellhorst
Copy link
Collaborator Author

FWuellhorst commented Dec 29, 2025

@MartinRaetz @TobiasSpratte
I added regression tests which simulate the generated time-shifted mos in Modelica on different tilts and directions. You can create these and more plots with the new test_mos_simulation, executed as a plain python script locally.

Tilted roof first day of year diffuse radiation

plots_summer=False_HDifTilRoo

Tilted roof in summer direct radiation

plots_summer=True_HDirTilRoo

Overall, when exporting time zones shifts are valid. Shifting larger than 6-8 hours compared to the imported data, the values become higher in the plot, which is caused by the values of the next day in the original data.
Still, I stored the _imported_timezone (which is set in the import classes with "set_imported_timezone" and added a warning if someone changes the default timezone of the import.

@FWuellhorst FWuellhorst merged commit 8916f63 into development Dec 30, 2025
17 checks passed
@FWuellhorst FWuellhorst deleted the 50_timezone branch December 30, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export time zone - customizable or similar to import

4 participants