-
Notifications
You must be signed in to change notification settings - Fork 0
#50 enable export of timezone from metadata in to-mos #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MartinRaetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @FWuellhorst.
Can you confirm that the tests will cover sufficiently the new feature? Since its the new default the regression tests should be running on the new default.
# Conflicts: # aixweather/core_data_format_2_output_file/to_epw_energyplus.py # aixweather/core_data_format_2_output_file/to_mos_TMY3.py # aixweather/transformation_to_core_data/EPW.py
|
@MartinRaetz: I checked locally in Dymola for a single test and the feature works well for Modelica. @TobiasSpratte : Can you check the with E+ if the exported .epw with the timezone also works as expected, especially in combination with SPAWN and mos. I don't know how to access the weather results from E+ in Spawn. Future development options:
What do you think @MartinRaetz ? I would do that in other issues to keep this one focused on the timezone aspect. |
|
I have checked the exported .mos and .epw files in EnergyPlus, Spawn and Modelica and everything works as expected. Thank you @FWuellhorst ! |
… avoid HTTP errors in CI
MartinRaetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this major PR! I think its a very helpful modification to meet the users expectations!
add workflow.yml
# Conflicts: # aixweather/imports/TRY.py # tests/test_TRY.py
|
@MartinRaetz @TobiasSpratte Tilted roof first day of year diffuse radiation
Tilted roof in summer direct radiation
Overall, when exporting time zones shifts are valid. Shifting larger than 6-8 hours compared to the imported data, the values become higher in the plot, which is caused by the values of the next day in the original data. |



This closes #50.
Todos: