-
-
Notifications
You must be signed in to change notification settings - Fork 95
[Lidarr] Port to tidal-dl-ng #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 8357e72.
|
I get very close, but I have FFMPEG issues with these changes - looks like there is a fix here?mkudrjasevs@ea95270 |
|
It might be a simpler fix to just postpone the installation of tidal-dl-ng. That, or you've encountered some other odd error. I'll have to check that one out tomorrow. I've also had a test running in an existing environment with quite the backlog, which has surfaced another potentially upstream issue. For some reason, it'll be deauthed every few hours. I think that's either a tidal-dl-ng issue or Tidal not liking it downloading so much in a relatively short time period. |
|
I manually went through your github and found all the new files and wget-ed then into my install. Probably needs another test from someone more experienced than I to confirm. |
|
So it worked for you? It might have just needed something updated to a newer version, and that happened to fix it. |
|
Well, new issue. tidal-dl-ng got taken down on PyPi as well. My Lidarr container updated again, and broke when it couldn't pull it. Looks like this might need to be converted to use one of the forks of tidal-dl-ng. |
Since
tidal-dlis still broken andtidal-dl-ngworks, port the audio downloading script to it.Fixes #391, #374, #289, and maybe more.
Changes
tidal-dlcalls fortidal-dl-ng./config/extended/tidal_dl_ngviaXDG_CONFIG_HOMEand ensured directories exist.tidal-dl-ngenums and setdownload_base_path/quality_audiothroughtidal-dl-ng cfg.tidal-dl-ngformat and switched setup to installtidal-dl-ng.Breaks
The port does require some changes to work.
AudioandTidalVideoDownloaderservices must be updated, of course.tidal-dl.jsonfile contents are changed. This could be worked around with a rename if desired. If so, the URL in the setup script will break.Testing
I haven't tested every possible configuration, but it seems to work with lossless/master for the quality. I've tested artists with a mix of lossless and "Max" with no issues. I also started it on my server, and it is having some upstream issues with existing files.
When testing, I mostly just followed the existing setup directions and then copied over the new Audio and video services (including renaming) and the new tidal config file.
Additionally, I don't personally use the video downloading scripts, but it seems to be working.
Potential Issues
For context, since Lidarr started having issues from the MusicBrainz change, I've mostly been doing things manually. Then
tidal-dlbroke, and I tried fixing it, then gave up after realizing I was basically rewriting the thing. So, I moved to usingtidal-dl-ng.However, since I started using it, there has apparently been some kind of take-down on the original repo. The PyPi package is still up and working, for now, but the GitHub repo is gone.
For reference, here's the PyPi package: https://pypi.org/project/tidal-dl-ng/
But the GitHub repo is a 404: https://github.com/exislow/tidal-dl-ng
If that's an issue, several forks exist that could be used. I haven't found one on PyPi yet, but they could just be installed from GitHub directly like this:
uv pip install --system --upgrade --no-cache-dir --break-system-packages "git+https://github.com/FunWarry/tidal-dl-ng-For-DJ.git@main"