Skip to content

Conversation

@gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Jan 7, 2026

The basics

The details

Resolves

Fixes #9537

Proposed Changes

This PR fixes two bugs with identical presentation:

  • When workspace comments were dragged over the toolbox (to delete them), they appeared behind the toolbox. They were being added to the drag layer correctly, but on focus moved themselves to the block layer. Now, they just append themselves to their current parent on focus, which preserves the raise-on-focus behavior but also keeps them on whatever layer they're currently on, and thus correctly z-ordered.
  • When blocks were dragged over the toolbox, their attached bubbles appeared behind the toolbox. Bubbles are not children of blocks in the DOM; they live on a separate, unrelated layer and were not being moved to the drag layer with their parent blocks. They now are.

@gonfunko gonfunko requested a review from a team as a code owner January 7, 2026 19:02
@gonfunko gonfunko requested a review from maribethb January 7, 2026 19:02
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 7, 2026
@gonfunko gonfunko merged commit d331336 into main Jan 8, 2026
12 of 13 checks passed
@gonfunko gonfunko deleted the drag-order branch January 8, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace comments and bubbles appear behind the toolbox when dragged

3 participants