Fix build deprecation warnings #1317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cursor Agent can help with this pull request. Just |
zetter-rpf
temporarily deployed
to
previews/1317/merge
GitHub Actions
Inactive
cursor
bot
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
81f8f2b to
622747f
Compare
cursor
bot
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
622747f to
11f0fe9
Compare
zetter-rpf
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
11f0fe9 to
7f4e2b9
Compare
zetter-rpf
temporarily deployed
to
previews/1317/merge
GitHub Actions
Inactive
zetter-rpf
temporarily deployed
to
previews/1317/merge
GitHub Actions
Inactive
zetter-rpf
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
1b1f1c3 to
fe3bf52
Compare
zetter-rpf
temporarily deployed
to
previews/1317/merge
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets removal of yarn build deprecation warnings by modernizing the Sass toolchain/config and updating related dependency data, while also aligning Plotly styling/assets and adding a Plotly-focused Python sample project for validation.
Changes:
- Upgrade
sass-loaderand configure it to use the modern Sass JS API, including adding Sass load paths. - Update SCSS imports/asset references (design system, toastify, material symbols, plotly CSS) to avoid deprecated patterns.
- Refresh dependency lock data (
caniuse-lite) and bumpplotly.js; add a newpython-plotlysample project and link.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Updates resolved versions/checksums for sass-loader, plotly.js, and caniuse-lite to eliminate build warnings. |
webpack.config.js |
Switches sass-loader to modern API mode and sets Sass loadPaths for module resolution. |
src/web-component.html |
Adds python-plotly to the sample project picker. |
src/projects/python-plotly.json |
Introduces a new Python sample that exercises Plotly support. |
src/assets/stylesheets/InternalStyles.scss |
Removes Toastify SCSS import (Toastify styling now sourced via external stylesheet bundle). |
src/assets/stylesheets/ExternalStyles.scss |
Updates/standardizes external library style imports, including Plotly/Toastify/material symbols. |
package.json |
Bumps sass-loader and plotly.js dependency versions to match warning-fix strategy. |
AGENTS.md |
Updates contributor/agent guidance (notably around changelog/release notes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zetter-rpf
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
fe3bf52 to
1b1f1c3
Compare
Warning fixed: - "Sass @import rules are deprecated" emitted from "react-toastify/scss/main.scss" during yarn build. Approach: - Stop compiling Toastify Sass source and import the packages compiled CSS (react-toastify/dist/ReactToastify.css) instead. - Remove the upstream SCSS @use from InternalStyles.scss. Why this approach: - Preserves Toastify styling behavior while eliminating upstream Sass deprecation output in our build. - Avoids carrying or maintaining local forks of third-party styles. Alternatives considered: - Keep importing SCSS and suppress warnings globally: rejected because it hides actionable deprecations. - Patch Toastify Sass locally: rejected due to maintenance overhead and divergence from upstream. Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Warnings fixed: - "Sass @import rules are deprecated" from material-symbols/sharp.scss. - "Global built-in functions are deprecated" (to-lower-case, str-index, str-slice, str-length) from material-symbols/_core.scss. Approach: - Replace material-symbols/sharp.scss import with material-symbols/sharp.css in ExternalStyles.scss. Why this approach: - Uses upstream distributed CSS, so our build no longer compiles third-party Sass that triggers deprecation warnings. - Keeps the same font-face and utility class output with minimal risk. Alternatives considered: - Keep SCSS and silence deprecations: rejected because it masks dependency issues broadly. - Patch material-symbols Sass locally: rejected due to long-term maintenance burden. Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Warning fixed: - "The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0." repeated during yarn build. Approach: - Upgrade sass-loader from v10 to v13 (Node 16 compatible) and configure sass-loader with api: "modern". - Add Sass load paths for node_modules so package imports resolve under the modern API. - Update design-system-react @forward path to its explicit distributed SCSS entrypoint for reliable modern resolution. Why this approach: - Removes dependence on the deprecated Sass legacy API instead of suppressing the warning. - Keeps compatibility with current CI Node runtime while modernizing Sass integration. Alternatives considered: - Stay on sass-loader v10 and suppress the legacy API warning: rejected because this leaves deprecated behavior in place. - Jump to sass-loader v14+: rejected because those versions require newer Node than current CI. Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Warning fixed: - "Sass @import rules are deprecated" emitted from plotly.js/src/css/style.scss imports during yarn build. Use the built plotly styles Newer versions of plotly have the built styles that we can use.
zetter-rpf
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
1b1f1c3 to
6aa4021
Compare
Warning fixed: - "Browserslist: caniuse-lite is outdated" shown during yarn build. Approach: - Refresh caniuse-lite/baseline browser mapping data in the lockfile using update-browserslist-db. Why this approach: - This directly resolves the warning with the officially recommended update path. - Keeps target browser data current for autoprefixing/transpilation decisions. Alternatives considered: - Ignore the warning: rejected because stale browser data can skew build targets. - Pin an older browserslist stack: rejected because it delays routine ecosystem updates. Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Changes: - Clarify that CHANGELOG.md should not be updated; GitHub Releases are the source of truth. - Add commit guidance requiring descriptive messages with rationale and alternatives when relevant. Why: - Aligns repository instructions with current release-note process. - Improves commit history quality and review context for future maintenance. Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Plotly does have an e2e test, but I wanted to be able to check the styling of it after the 3.3 upgrade
zetter-rpf
force-pushed
the
cursor/build-deprecation-warnings-a24d
branch
from
6aa4021 to
5cdb6a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1139
Remove all
yarn builddeprecation warnings by updating Sass imports,sass-loaderconfiguration, andcaniuse-litedata.See commits for more details.