Only deploy to staging if tests pass #1320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently changed our github branch setting to allow merges without the branch being up to date with main as this made merging branches harder and take more time. This increases the risks of test failing on main due to behaviour conflicts after merging. Because of this, it would be safer to block deploys if the tests fail. I've decided not to have this check to the deploy branch job as it's helpful to get this deployed and usable on a PR even if there are some errors in the build.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI/CD GitHub Actions workflow so that staging deployments from main are gated by successful CI checks, reducing the risk of deploying a broken build after merging branches that may not be up-to-date with main.
Changes:
- Add job dependencies so
deploy-mainwaits forlint,test, andtest-cypressto complete successfully before deploying to staging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently changed our github branch setting to allow merges without the branch being up to date with main as this made merging branches harder and take more time. This increases the risks of test failing on main due to behaviour conflicts after merging.
Because of this, it would be safer to block deploys if the tests fail.
I've decided not to have this check to the deploy branch job as it's helpful to get this deployed and usable on a PR even if there are some errors in the build.