Made save / restore size and position of the main window using wxConfig#30
Open
ManeFunction wants to merge 3 commits intoRavbug:masterfrom
Open
Made save / restore size and position of the main window using wxConfig#30ManeFunction wants to merge 3 commits intoRavbug:masterfrom
ManeFunction wants to merge 3 commits intoRavbug:masterfrom
Conversation
Owner
|
Thanks for the PR! I will take a look when I have a chance. |
Owner
|
I tested it on both mac and windows, and while this works on mac, it does not work on windows. The call to config->Read on windows always fails. Not sure if this is an issue with wxConfig or with our usage of it here. |
Contributor
Author
|
Thank you for the test! I'll check this out a bit later if no one helps with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a feature to keep main window's size and position, and not reset it on each launch. Used default wxConfig feature already included in project, so no any new tools here.
Tested on Mac, can't test it on Windows or Linux at the time. Sorry if I did something wrong, C++ is not my main language.