Change 'expand-home' to support Unix style paths on windows.#73
Open
nurous wants to merge 2 commits intoRaynes:masterfrom
Open
Change 'expand-home' to support Unix style paths on windows.#73nurous wants to merge 2 commits intoRaynes:masterfrom
nurous wants to merge 2 commits intoRaynes:masterfrom
Conversation
Owner
|
#87 Solves this, right? |
|
This problem is not solved by #87: As you see, if a forward slash is used as path separator, the path is corrected incorrectly, while it is correctly constructed with a backslash. |
Author
|
@Raynes Do you want to merge this or should I close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expand-home does not add the home to the path when on windows and the path string uses unix style path separators (which is generally OK in Java). Fix seems to be just ensure the path passed in is converted to a File object first which will convert the unix style separators to File/separator.