Skip to content

Conversation

@eddelbuettel
Copy link
Member

No description provided.

@eddelbuettel eddelbuettel requested a review from Copilot August 14, 2025 12:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates RcppArmadillo from version 14.6.2-1 to 14.6.3-1, upgrading the bundled Armadillo C++ library to version 14.6.3. The primary purpose is to fix OpenMP-related crashes in Cube::slice() on Arm64 CPUs by upgrading the minimum required OpenMP version from 3.1 to 4.0.

Key changes:

  • Upgraded minimum OpenMP requirement from version 3.1 (201107) to 4.0 (201307)
  • Added seq_cst memory order clause to atomic read/write operations for thread safety
  • Updated version numbers and documentation across all relevant files

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
inst/include/armadillo_bits/compiler_setup.hpp Updated OpenMP version checks and warning messages to require 4.0+
inst/include/armadillo_bits/arma_version.hpp Incremented patch version from 2 to 3
inst/include/armadillo_bits/arma_forward.hpp Added seq_cst memory order to atomic operations
inst/include/armadillo_bits/Cube_meat.hpp Added seq_cst memory order to atomic operations in Cube class
inst/NEWS.Rd Added changelog entry for 14.6.3-1 release
configure.ac Updated version string in autoconf configuration
configure Updated generated configure script with new version
DESCRIPTION Updated package version and date
ChangeLog Added entry documenting the version update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@eddelbuettel
Copy link
Member Author

Reverse-dependency checks reveal one regression with a package also failing at CRAN, see the run summary.

@eddelbuettel eddelbuettel merged commit 988d037 into master Aug 15, 2025
2 checks passed
@eddelbuettel eddelbuettel deleted the feature/arma_14.6.3 branch August 15, 2025 11:06
@eddelbuettel
Copy link
Member Author

The previously noted issue has been addressed by an upstream update in that package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants