Skip to content

Conversation

@aitap
Copy link
Member

@aitap aitap commented Dec 11, 2025

If the return value is not protected, ENC2UTF8() may end up returning a different CHARSXP pointer after the original one is garbage-collected, causing us to lose the TRUELENGTH mark. Solution: store the names of every list item in a separate list.

Fixes: #7452

#6694 will depend on this because it needs a few more changes to memory management inside rbindlist. Can instead be integrated into #6694.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (2654599) to head (1c025c0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7461   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          87       87           
  Lines       16689    16694    +5     
=======================================
+ Hits        16529    16534    +5     
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

No obvious timing issues in HEAD=fix-7452
Comparison Plot

Generated via commit c8d051e

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 13 seconds
Installing different package versions 10 minutes and 31 seconds
Running and plotting the test cases 2 minutes and 39 seconds

@ben-schwen ben-schwen added this to the 1.19.0 milestone Dec 22, 2025
Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY

@aitap aitap merged commit dc1dbe9 into master Dec 22, 2025
12 of 13 checks passed
@aitap aitap deleted the fix-7452 branch December 22, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbindlist doesn't protect the ENC2UTF8 temporaries

2 participants