More test fixes for when translations are present #7478
Merged
+43
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capture.output() tests are fine in many places, but these ones tested for messages that have since been translated and must be skipped in foreign more.
Where capture.output() was previously used to test the absence of messages, use notOutput= instead so that the test will be skipped. While the test succeeded anyway due to the captured output containing neither the original untranslated message (being matched) nor its translation (that could be printed if a regression happened), skipping the test is more fair.
When working in foreign mode, count the occurrences of tests for message content (which are essentially skipped) and report the number if it's non-zero.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7478 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 86 86
Lines 16618 16629 +11
=======================================
+ Hits 16463 16474 +11
Misses 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=more-foreign-tests Generated via commit 01857cb Download link for the artifact containing the test results: ↓ atime-results.zip
|
Instead, test substitute(x) for %iscall% "print" to decide whether to print the x before testing the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch all tests that depend on untranslated output being produced to use
output=ornotOutput=so that translation doesn't break them any more. Skip test 1590.14 because it fails due to the bytes having completely different meanings on Windows when the ANSI codepage is not 1252.This will still fail in interesting ways (e.g.
translateChar()warnings from the parser) on systems that cannot represent Latin-1 characters in the native encoding. We still need #7388 and a few more fixes for that.