Skip to content

Conversation

@MichaelChirico
Copy link
Member

Closes #6480. I assume existing tests are enough -- R/groupingsets.R has 100% coverage:

https://app.codecov.io/gh/Rdatatable/data.table/blob/master/R%2Fgroupingsets.R

No NEWS since this is purely internal.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (4d30c7f) to head (1a81a2e).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7576      +/-   ##
==========================================
- Coverage   99.02%   99.02%   -0.01%     
==========================================
  Files          87       87              
  Lines       16750    16742       -8     
==========================================
- Hits        16587    16579       -8     
  Misses        163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

  • HEAD=bit64-workaroud slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 1a81a2e

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 4 seconds
Installing different package versions 11 minutes and 30 seconds
Running and plotting the test cases 4 minutes and 26 seconds

Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Test 2083.2 covers the INT64 NA rbindlist case.

@ben-schwen ben-schwen merged commit c6a1991 into master Jan 9, 2026
12 checks passed
@ben-schwen ben-schwen deleted the bit64-workaroud branch January 9, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

groupingsets handling int64 does not need workaround anymore

2 participants