-
-
Notifications
You must be signed in to change notification settings - Fork 217
build: Use Gradle credentials system #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request modernizes the Gradle authentication mechanism by switching from manual credential configuration to Gradle's built-in PasswordCredentials system for GitHub Packages authentication. The changes standardize how credentials are passed from CI/CD workflows to the Gradle build.
Key changes:
- Replaced manual username/password assignment in build.gradle.kts with PasswordCredentials system
- Updated GitHub Actions workflows to use Gradle project properties via environment variables
- Added repository name to enable Gradle's credential lookup mechanism
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| build.gradle.kts | Simplified credentials configuration by using PasswordCredentials class and added repository name for credential lookup |
| .github/workflows/release.yml | Updated environment variables to use Gradle project property naming convention for credentials |
| .github/workflows/build_pull_request.yml | Updated environment variables to use Gradle project property naming convention for credentials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Switch to PasswordCredentials when during authentication with ghcr
nts:
List of what repository have PR submitted see: ReVanced/revanced-manager-downloader-template#16 (comment)