dont find entities which are marked for deletion #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was leading to vscript crashes in a typical while find entity loop especially if ran every tick. entity would be marked for deletion and deemed invalid with IsValid function, but the find function would resurrect it in the same tick, then trying to use the resurrected handle shortly afterwards would crash the game. Also now doing Destroy in the typical while find loop is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was leading to vscript crashes in a typical while find entity loop especially if ran every tick. entity would be marked for deletion and deemed invalid with IsValid function, but the find function would resurrect it in the same tick, then trying to use the resurrected handle shortly afterwards would crash the game. Also now doing Destroy in the typical while find loop is fine