Add new type that can be parametrized.#54
Open
thinkofher wants to merge 1 commit intoRedisGraph:masterfrom
Open
Add new type that can be parametrized.#54thinkofher wants to merge 1 commit intoRedisGraph:masterfrom
thinkofher wants to merge 1 commit intoRedisGraph:masterfrom
Conversation
This commit adds new type: "int64" that can be used by (*Graph).ParameterizedQuery method. According to the "Cypher Coverage" section from RedisGraph documentation: 64-bit signed integer is supported literal type. This change will allow, for example, to use time.Now().Unix() as parameter for previously mentioned ParameterizedQuery. Before this change, using int64 as parameter for ParameterizedQuery result with panic, although using int64 is very common when writing go code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When using
redisgraph-goyou cannot simply passtime.Now().Unix()as ParameterizedQuery parameter, which I though is common behavior. Example code below.Probably I can use
toIntegerRedisGraphs function in query, but I still won't be able to passint64as property inPropertiesfield of Nodes.What do you think about that?