fix(project): add empty path check, throw error on unresolved path #2437

aim4ik11 · 2025-12-03T10:28:14Z

What/Why/How?

Currently extends property parser in config accepts not existing refs which causes builder to attempt to resolve those and throw hard error which could be hard to debug for user. I suggest adding more descriptive error message so that builder displays it

Reference

Issue

Check yourself

Code changed? - Tested with Redoc/Realm/Reunite (internal)
All new/updated code is covered by tests
New package installed? - Tested in different environments (browser/node)
Documentation update considered

Security

The security impact of the change has been considered
Code follows company security practices and guidelines

changeset-bot · 2025-12-03T10:28:18Z

⚠️ No Changeset found

Latest commit: 4bf6ed5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-12-03T10:29:53Z

Command	Mean [s]	Min [s]	Max [s]	Relative
`redocly lint resources/rebilly.yaml`	1.441 ± 0.019	1.407	1.472	1.00
`redocly-next lint resources/rebilly.yaml`	1.457 ± 0.038	1.404	1.537	1.01 ± 0.03

github-actions · 2025-12-03T10:30:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	78.65% (🎯 78%)	6165 / 7838
🔵	Statements	78.06% (🎯 78%)	6372 / 8162
🔵	Functions	82.21% (🎯 82%)	1253 / 1524
🔵	Branches	70.47% (🎯 70%)	4253 / 6035

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/core/src/lint.ts	94.23%	88.23%	100%	94.11%	112-123, 146
packages/core/src/bundle/bundle.ts	94.73%	86.66%	100%	94.73%	100
packages/core/src/config/bundle-extends.ts	100%	94.44%	100%	100%
packages/core/src/config/config-resolvers.ts	74.25%	60.42%	93.33%	75%	67, 70, 90-93, 143, 184, 250, 261, 270, 283, 293, 296-300, 305-314, 337-339, 349, 352, 355, 358, 361, 374-376, 380, 386, 389, 392-395, 398-401, 404-407, 421-423, 430, 433, 436, 439, 442, 445, 475-486, 497-502
packages/core/src/config/config.ts	62.84%	65.67%	76.92%	63.19%	170-197, 223, 227, 231-249, 281, 299-319, 398-428
packages/core/src/config/load.ts	90%	68.75%	100%	92.3%	51, 73, 97, 140
packages/core/src/rules/config/config-no-unresolved-refs.ts	90.62%	76.92%	100%	100%	13, 31, 44
packages/core/src/types/redocly-yaml.ts	83.56%	67.44%	92.3%	82.85%	276-295, 390-397, 399, 544-549, 552-557, 560-565

Generated in workflow #8462 for commit 4bf6ed5 by the Vitest Coverage Report Action

RomanHotsiy · 2025-12-03T11:36:21Z

packages/core/src/config/bundle-extends.ts

  const resolvedExtends = (node.extends || [])
-    .map((presetItem: string) => {
+    .map((presetItem, index) => {
+      if (typeof presetItem !== 'string' || !presetItem.trim()) {


it's missing file path of where it happens

AlbinaBlazhko17 · 2025-12-16T19:14:23Z

packages/core/src/config/bundle-extends.ts


  const resolvedExtends = (node.extends || [])
-    .map((presetItem: string) => {
+    .map((presetItem, index) => {


Let's investigate if we can use reportUnresolvedRef in some place to resolve this issue.
https://github.com/Redocly/redocly-cli/blob/main/packages/core/src/rules/common/no-unresolved-refs.ts

RomanHotsiy · 2026-01-08T07:39:45Z

packages/core/src/rules/config/config-no-unresolved-refs.ts

+    const exts = (node as any).extends;
+    if (!Array.isArray(exts)) return;
+
+    exts.forEach((item, index) => {


let's use regular for or for of

RomanHotsiy · 2026-01-08T07:40:38Z

packages/core/src/types/redocly-yaml.ts

-      } as PropType;
-    },
-  } as PropType,
+  // extends: {


why is this commented out?

github-actions · 2026-01-21T14:33:58Z

CLI Version	Mean Time ± Std Dev (s)	Relative Performance (Lower is Faster)
cli-latest	3.670s ± 0.034s	▓ 1.00x (Fastest)
cli-next	3.684s ± 0.036s	▓ 1.00x

tatomyr · 2026-01-21T16:17:10Z

packages/core/src/types/redocly-yaml.ts

  properties: configGovernanceProperties,
 };

+const ConfigGovernanceList: NodeType = {


FYI, this name will likely be changed in #2488.

fix(project): add empty path check, throw error on unresolved path

e3069e3

aim4ik11 self-assigned this Dec 3, 2025

aim4ik11 requested a review from a team as a code owner December 3, 2025 10:28

chore(project): add tests for bundle extends

2ad30b5

RomanHotsiy reviewed Dec 3, 2025

View reviewed changes

aim4ik11 added 2 commits December 3, 2025 15:00

fix(project): change report, fix undefined

c098724

fix: fix test error equality

b9e1b8c

AlbinaBlazhko17 reviewed Dec 16, 2025

View reviewed changes

aim4ik11 added 3 commits December 18, 2025 14:26

chore(project): turn preset error in warning

5d6e3f2

chore: add location to preset

0dae324

chore: add linting rule for extends

e17ae00

RomanHotsiy reviewed Jan 8, 2026

View reviewed changes

aim4ik11 added 2 commits January 21, 2026 12:33

Merge branch 'main' into improve-bundle-extends

52e61f3

add tests

409ece8

tatomyr reviewed Jan 21, 2026

View reviewed changes

aim4ik11 added 2 commits January 22, 2026 09:43

replace forEach with for of

6882a0e

Merge branch 'main' into improve-bundle-extends

4bf6ed5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(project): add empty path check, throw error on unresolved path #2437

fix(project): add empty path check, throw error on unresolved path #2437

Uh oh!

aim4ik11 commented Dec 3, 2025

Uh oh!

changeset-bot bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

RomanHotsiy Dec 3, 2025

Uh oh!

AlbinaBlazhko17 Dec 16, 2025

Uh oh!

RomanHotsiy Jan 8, 2026

Uh oh!

RomanHotsiy Jan 8, 2026

Uh oh!

github-actions bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

tatomyr Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(project): add empty path check, throw error on unresolved path #2437

Are you sure you want to change the base?

fix(project): add empty path check, throw error on unresolved path #2437

Uh oh!

Conversation

aim4ik11 commented Dec 3, 2025

What/Why/How?

Reference

Check yourself

Security

Uh oh!

changeset-bot bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

RomanHotsiy Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

AlbinaBlazhko17 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

RomanHotsiy Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

RomanHotsiy Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tatomyr Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot bot commented Dec 3, 2025 •

edited

Loading

github-actions bot commented Dec 3, 2025 •

edited

Loading

github-actions bot commented Dec 3, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading