Skip to content

Commit 8004c75

Browse files
committed
Merge pull request #98301 from aaronp64/gdscript_validate_property
Avoid unnecessary `Dictionary` conversions in `GDScriptInstance::validate_property`
2 parents 598cfbd + aa1d469 commit 8004c75

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

modules/gdscript/gdscript.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1862,14 +1862,14 @@ Variant::Type GDScriptInstance::get_property_type(const StringName &p_name, bool
18621862
}
18631863

18641864
void GDScriptInstance::validate_property(PropertyInfo &p_property) const {
1865-
Variant property = (Dictionary)p_property;
1866-
const Variant *args[1] = { &property };
1867-
18681865
const GDScript *sptr = script.ptr();
18691866
while (sptr) {
18701867
if (likely(sptr->valid)) {
18711868
HashMap<StringName, GDScriptFunction *>::ConstIterator E = sptr->member_functions.find(GDScriptLanguage::get_singleton()->strings._validate_property);
18721869
if (E) {
1870+
Variant property = (Dictionary)p_property;
1871+
const Variant *args[1] = { &property };
1872+
18731873
Callable::CallError err;
18741874
Variant ret = E->value->call(const_cast<GDScriptInstance *>(this), args, 1, err);
18751875
if (err.error == Callable::CallError::CALL_OK) {

0 commit comments

Comments
 (0)