Check Downloaded and Drag & Dropped Mods for Targetted Game and Warn If None #769
Conversation
…ere no compatible applications are found
TheBestAstroNOT
changed the title
|
Only works for drag and dropping right now, working on support for mods installed via the R2 protocol (it isn't going well) |
|
PR for #751 |
|
I also made these two mods to test it https://github.com/TheBestAstroNOT/psychic-happiness/releases/tag/1.0.0 |
|
@dreamsyntax are there any changes you would like to see? |
|
Ok, now I've properly tested this build. Drag & Drop "No" instead of "Cancel" makes more sense, since the mod itself still gets installed, we just don't set the supported app. Ideally there would be three options Since this happens after a download for example though, I think its fine to just change it to -- Mod Loader Download Button
R2 Links (Gamebanana)
|
|
@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with. |
I'll try later today. If you want to test in interim: If you add any exe renamed as tsonic_win.exe, it will add Sonic Heroes as a gamebanana source. You'll be able to see 64 Mario skin for that game in the download manager, which has the issue. |
1 similar comment
I'll try later today. If you want to test in interim: If you add any exe renamed as tsonic_win.exe, it will add Sonic Heroes as a gamebanana source. You'll be able to see 64 Mario skin for that game in the download manager, which has the issue. |
Ok it seems to be working
|
| public XamlResourceMessageBoxOkCancel(string titleResourceName, string descriptionResourceName, string okButtonTextResourceName, string cancelButtonTextResourceName) : base(new XamlResource<string>(titleResourceName).Get(), new XamlResource<string>(descriptionResourceName).Get()) | ||
| public XamlResourceMessageBoxOkCancel(string title, string message, string okText, string cancelText) : base(title, message) | ||
| { | ||
| this.CancelBtn.Content = Lib.Static.Resources.ResourceProvider.Get<string>(cancelButtonTextResourceName); | ||
| this.OKBtn.Content = Lib.Static.Resources.ResourceProvider.Get<string>(okButtonTextResourceName); |
There was a problem hiding this comment.
Unless I'm missing something, wouldn't this replace every instance of Ok/Cancel to Yes/No?
There was a problem hiding this comment.
Uhh no? You are passing the text every time you call it. Plus other message boxes use another delegate to display their text. Only I'm using this one.
|
Tested. Feature works as expected now. @Sewer56 on any objections with the code? I left a comment about the resource, the rest looks fine. |
2 participants
No description provided.