RE1-T88 Still trying to fix FCM apns

[ucswift]

Summary by CodeRabbit

• Bug Fixes
  • Corrected Apple Push Notification field configuration to ensure proper delivery and display of push notifications on iOS devices.

[request-info]

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

[coderabbitai]

Walkthrough

The change removes top-level Apple Push Notification field mappings (badge, sound, type, category, eventCode) from the overrides.apns block in the NovuProvider's SendNotification method, relocating these fields to the nested payload.apns/aps structure while preserving overall payload shape.

Changes

Cohort / File(s)	Change Summary
APNS field relocation Providers/Resgrid.Providers.Messaging/NovuProvider.cs	Removed top-level apns field mappings (badge, sound, type, category, eventCode) from overrides.apns block; these fields now exist solely within nested payload.apns/aps structure; remaining payload and dictionary-based apns mapping unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that all five relocated fields (badge, sound, type, category, eventCode) are correctly mapped in the nested payload.apns/aps structure
• Confirm no functional behavior changes or side effects from the structural reorganization

Possibly related PRs

• CU-868f7hkrj Fixed Novu provider for ios and bugfix for voice. #237: Modifies the same NovuProvider.SendNotification method's APNS payload structure with similar field placement adjustments
• RE1-T88 Looking at using FCM to forward APNS messages with Novu #264: Also restructures APNS field allocation in NovuProvider.SendNotification, moving fields into nested payload.apns/aps constructs

Poem

🐰 Hop through the notification stack so bright,
Fields shuffle left, now deeper in sight,
APNS badges nestled within the aps frame,
Same message flows, but reorganized—what a game! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references a specific issue (RE1-T88) and describes the primary change (fixing FCM apns field mappings), making it directly related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b5e9eb and 8731add.

📒 Files selected for processing (1)

• Providers/Resgrid.Providers.Messaging/NovuProvider.cs (0 hunks)

💤 Files with no reviewable changes (1)

• Providers/Resgrid.Providers.Messaging/NovuProvider.cs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build
• GitHub Check: Analyze (csharp)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (csharp)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ucswift]

Approve

[github-actions]

This PR is approved.