Sourcery refactored main branch #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-12
to
+15
| print("Found " + str(len(results)) + " Results.") | ||
| print(f"Found {len(results)} Results.") | ||
|
|
||
| for i in results: | ||
| string = "" | ||
| for j in i: | ||
| string += j | ||
| string = "".join(i) |
Author
There was a problem hiding this comment.
Lines 12-17 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Use str.join() instead of for loop (
use-join) - Remove unnecessary calls to
str()from formatted values in f-strings (remove-str-from-fstring) - Simplify generator expression (
simplify-generator)
| titlePrinter() | ||
| check = rootcheck() | ||
| masterList = [] | ||
| blacklist = ('http://76qugh5bey5gum7l.onion') |
Author
There was a problem hiding this comment.
Lines 24-24 refactored with the following changes:
- Hoist statements out of for/while loops (
hoist-statement-from-loop)
Comment on lines
-25
to
+31
| html = str(content,'utf-8').replace('\t',' ').replace('\n',' ').replace('\r',' ').replace('\"','') | ||
| return html | ||
| return ( | ||
| str(content, 'utf-8') | ||
| .replace('\t', ' ') | ||
| .replace('\n', ' ') | ||
| .replace('\r', ' ') | ||
| .replace('\"', '') | ||
| ) |
Author
There was a problem hiding this comment.
Function onionHTML refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-59
to
+64
| ahmia = list(set(results)) | ||
| return ahmia | ||
| return list(set(results)) |
Author
There was a problem hiding this comment.
Function ahmia refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-63
to
-64
| results = [] | ||
| regex = r"https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.onion\/?[-a-zA-Z0-9@:%._\/+~#=]{1,256}" |
Author
There was a problem hiding this comment.
Function redditOnions refactored with the following changes:
- Move assignments closer to their usage (
move-assign) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-132
to
+148
| for i in onions: | ||
| temp.append((i.replace("<a href=","").replace(">",""))) | ||
| temp.extend(i.replace("<a href=","").replace(">","") for i in onions) | ||
| for i in temp: | ||
| if "http" in i: | ||
| if ".onion" not in i: | ||
| pass | ||
| else: | ||
| if ".onion" in i: | ||
| temp2.append(i) | ||
| elif "mailto:" in i: | ||
| pass | ||
| elif i.startswith("../"): | ||
| i = i.replace("../",inputURL+"/") | ||
| i = i.replace("../", f"{inputURL}/") | ||
| temp2.append(i) | ||
| elif i.startswith("/"): | ||
| temp2.append(inputURL+i) | ||
| else: | ||
| temp2.append(inputURL + "/" + i) | ||
| aTag = list(set(temp2)) | ||
| return aTag | ||
| temp2.append(f"{inputURL}/{i}") | ||
| return list(set(temp2)) |
Author
There was a problem hiding this comment.
Function aTag refactored with the following changes:
- Swap if/else to remove empty if body (
remove-pass-body) - Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation) - Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace a for append loop with list extend (
for-append-to-extend)
| def createDB(): | ||
| con = sqlite3.connect('output/deepminer.db') | ||
| return con | ||
| return sqlite3.connect('output/deepminer.db') |
Author
There was a problem hiding this comment.
Function createDB refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-9
to
+8
| con = sqlite3.connect('output/deepminer.db', timeout=30) | ||
| return con | ||
| return sqlite3.connect('output/deepminer.db', timeout=30) |
Author
There was a problem hiding this comment.
Function connectDB refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-69
to
+67
| results = cur.fetchall() | ||
| return results | ||
| return cur.fetchall() |
Author
There was a problem hiding this comment.
Function searchDB refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-86
to
+83
| results = cur.fetchall() | ||
| return results | ||
| return cur.fetchall() |
Author
There was a problem hiding this comment.
Function searchFTS refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!