Skip to content
This repository was archived by the owner on Feb 19, 2025. It is now read-only.

Conversation

@weirdal3333
Copy link

@weirdal3333 weirdal3333 commented Jan 10, 2025

Case sensitivity matters!
CloudFlare to cloudflare

Summary by Sourcery

Bug Fixes:

  • Correct the casing of "cloudflare" to ensure consistency.

Case sensitivity matters!
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 10, 2025

Reviewer's Guide by Sourcery

This pull request updates the newsmake.py file to handle case sensitivity issues. Specifically, it changes "CloudFlare" to "cloudflare".

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the naming convention for CloudFlare
  • Changed "CloudFlare" to "cloudflare" to address case sensitivity issues.
Channels/News_Channel/newsmake.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@larsenv
Copy link
Contributor

larsenv commented Jan 10, 2025

@weirdal3333 This code is deprecated because the News Channel is being rewritten AFAIK. Associated Press changed their API to use GraphQL at least with phones

https://apnews.com/graphql/delivery/ap/v1?extensions=%7B%22persistedQuery%22:%7B%22sha256Hash%22:%2221ba61211aa74b973fb613b2203125e63ffd42860b5428f4dc98ddd94cb2b429%22,%22version%22:1%7D%7D&operationName=AppConfigQuery&variables=%7B%22path%22:%22%5C/app%5C/config%22%7D
https://apnews.com/graphql/delivery/ap/v1?extensions=%7B%22persistedQuery%22:%7B%22sha256Hash%22:%22fa53000bbc8a5bb5b8a935b2b251f00cb016ff79961d643510ff0252cd432ea1%22,%22version%22:1%7D%7D&operationName=PageQuery&variables=%7B%22path%22:%22%5C/%22,%22voter%22:%22%22,%22week%22:%22%22%7D
https://apnews.com/graphql/delivery/ap/v1?extensions=%7B%22persistedQuery%22:%7B%22sha256Hash%22:%22fa53000bbc8a5bb5b8a935b2b251f00cb016ff79961d643510ff0252cd432ea1%22,%22version%22:1%7D%7D&operationName=PageQuery&variables=%7B%22path%22:%22%5C/%22,%22voter%22:%22%22,%22week%22:%22%22%7D
https://apnews.com/graphql/delivery/ap/v1?extensions=%7B%22persistedQuery%22:%7B%22sha256Hash%22:%22fa9bad7654bfcab62c029a17e739d70ffc866d51ff6df4dd55c8822f93709cb7%22,%22version%22:1%7D%7D&operationName=PageNavigationQuery&variables=%7B%22id%22:%220000018f-1135-dcea-afef-9f75cdf20000%22,%22locationKey%22:%22%22,%22q%22:%22%22%7D
https://apnews.com/graphql/delivery/ap/v1?extensions=%7B%22persistedQuery%22:%7B%22sha256Hash%22:%22fa53000bbc8a5bb5b8a935b2b251f00cb016ff79961d643510ff0252cd432ea1%22,%22version%22:1%7D%7D&operationName=PageQuery&variables=%7B%22path%22:%22%5C/us-news%22,%22voter%22:%22%22,%22week%22:%22%22%7D
https://apnews.com/graphql/delivery/ap/v1?extensions=%7B%22persistedQuery%22:%7B%22sha256Hash%22:%22d61508dd5f8c1d84fa6d49338e321266f56b4538c07c233564bb11300287d69c%22,%22version%22:1%7D%7D&operationName=StoryQuery&variables=%7B%22path%22:%22%5C/article%5C/biden-poll-low-ratings-obama-trump-390f25a858bf4cdec28719a2fe17b525%22%7D
I also have found http://apnews.com/index.rss from the endpoint but it does not function

Unless youre trying to help WiiLink I dont see a point in updating this. News Channel is the only one which isn't rewritten to use golang

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants