Open
Conversation
Author
|
Oops, I didn't realize there was already an open pull request for the same thing. Should have looked beforehand, but it was such a small change, what were the odds... Anyway, the solutions are similar but not identical, so interesting to compare at least. |
|
@okoskimi I personally find your solution cleaner than mine. |
andyfleming
reviewed
Dec 27, 2020
|
|
||
| module.exports = merge.smart(baseConfig, { | ||
| target: 'electron-main', | ||
| watch: true, |
There was a problem hiding this comment.
If you add this, I believe you need the inverse on webpack.main.prod.config.js since it inherits the config from this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was looking for an electron-with-react-and-typescript template and yours looks very good. It doesn't support automatic reload for the main part after code changes though, so I created a patch for that. It uses the nodemon-webpack-plugin to automatically restart electron after changes in the main part.
Caveat: I'm new to electron, so I can't rule out unforeseen side effects, but as far as I could tell the patch works as desired.
BR,
--Oskari