Sort by premium when the order type is defined #2146 #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Luquitasjeffrey I tried in my local but it doesn´t seem to respond |
|
I fixed it, but it's my first time and i'm a junior. This is my solution: https://github.com/Libertrue/robosats/tree/fix-premium-sort-issue-2146 If you could spare a little help, @KoalaSat , I'd love to put a lot more effort into helping Robosats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the order list so that when a user selects buy or sell, orders are automatically sorted by premium:
Buy orders: Sorted ascending — most favorable premiums first.
Sell orders: Sorted descending — most favorable premiums first.