Use typedoc warnings to find and fix partially-hidden APIs#1058
Closed
EzraBrooks wants to merge 3 commits intodevelopfrom
Closed
Use typedoc warnings to find and fix partially-hidden APIs#1058EzraBrooks wants to merge 3 commits intodevelopfrom
EzraBrooks wants to merge 3 commits intodevelopfrom
Conversation
EzraBrooks
commented
Nov 12, 2025
EzraBrooks
changed the title
EzraBrooks
force-pushed
the
use-typedoc-warnings-to-find-broken-apis
branch
2 times, most recently
from
6688418 to
676c70d
Compare
EzraBrooks
force-pushed
the
use-typedoc-warnings-to-find-broken-apis
branch
from
676c70d to
81c6380
Compare
EzraBrooks
force-pushed
the
use-typedoc-warnings-to-find-broken-apis
branch
from
81c6380 to
405292f
Compare
Contributor
Author
|
Superseded by #1073. I figure changing the API of actionlib at this point doesn't actually make sense since extracting it from the core package is one of the first things I'll do after cutting 2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used typedoc's warnings about unexported types being referred to in the public API to find a bunch of stuff that should be either exported or made private. Some stuff ended up being deleted because when it was made private it had no references!
Public API changes
A bunch of stuff that I believe to be implementation details got moved from public to private. Please double-check me, but clearly none of the stuff was used in the examples or integration tests since those are still building.
I also changed a couple signatures in the math library to have their members be
number | undefinedinstead ofnumber | nullbecause the existing API requiring users to specifynullwas lame and probably wasn't actually even being used that way in practice before strict typing.