Skip to content

fix: resolve memory leak in MediaRecorder event listeners #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepak0x wants to merge 2 commits into
base: develop
Choose a base branch
from
+29 −13
Open

fix: resolve memory leak in MediaRecorder event listeners #1077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d326005
fix: resolve memory leak in MediaRecorder event listeners
deepak0x Jan 17, 2026
d90da51
Merge remote-tracking branch 'upstream/develop' into fix/media-record…
deepak0x Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions packages/react/src/hooks/useMediaRecorder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,29 @@ export function useMediaRecorder({ constraints, onStop, videoRef }) {
const stream = await getStream(constraints, true);
chunks.current = [];
const _recorder = new MediaRecorder(stream);
_recorder.start();
setRecorder(_recorder);
_recorder.addEventListener('dataavailable', (event) => {

const handleDataAvailable = (event) => {
chunks.current.push(event.data);
});
_recorder.addEventListener('stop', () => {
};

const handleStop = () => {
onStop && onStop(chunks.current);
});
_recorder.removeEventListener('dataavailable', handleDataAvailable);
_recorder.removeEventListener('stop', handleStop);
};

_recorder.addEventListener('dataavailable', handleDataAvailable);
_recorder.addEventListener('stop', handleStop);

_recorder.start();
setRecorder(_recorder);
}

async function stop() {
if (recorder) {
recorder.stop();
if (recorder.state !== 'inactive') {
recorder.stop();
}
(await getStream()).getTracks().forEach((track) => track.stop());
}
}
Expand Down Expand Up @@ -77,17 +87,23 @@ export function useNewMediaRecorder({ constraints, videoRef, onStop }) {

chunks.current = [];
const _recorder = new MediaRecorder(stream);
_recorder.start();
setRecorder(_recorder);

_recorder.addEventListener('dataavailable', (event) => {
const handleDataAvailable = (event) => {
chunks.current.push(event.data);
});
};

_recorder.addEventListener('stop', () => {
const handleStop = () => {
setRecordingData(new Blob(chunks.current, { type: 'video/mp4' }));
onStop && onStop(chunks.current);
});
_recorder.removeEventListener('dataavailable', handleDataAvailable);
_recorder.removeEventListener('stop', handleStop);
};

_recorder.addEventListener('dataavailable', handleDataAvailable);
_recorder.addEventListener('stop', handleStop);

_recorder.start();
setRecorder(_recorder);
}

async function stopRecording() {
Expand Down