fix: default browser setting

[Rohit3523]

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1732

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

• Bug Fixes
  • Fixed default browser selection logic to correctly identify the currently selected option
  • Improved translation handling for browser option labels in the selection interface

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The DefaultBrowserView component was modified to fix browser selection and translation display issues. A new type TType defines valid browser options, the changeDefaultBrowser function now accepts typed values and resolves them against available browsers, and the selection comparison logic switched from title-based to value-based matching. Translation flags were updated to properly render translated browser names.

Changes

Cohort / File(s)	Summary
Browser Selection & Translation app/views/DefaultBrowserView/index.tsx	Introduced TType union type for browser options; changed IBrowsersValues.title from string to TType; updated changeDefaultBrowser to resolve typed values against DEFAULT_BROWSERS and BROWSERS with fallback; switched isSelected logic from title comparison to value comparison (item.value === browser); enabled translation rendering by changing translateTitle from false to true

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: i18n missing translation and duplicated picker #6869: Modifies DefaultBrowserView's title translation handling and the translateTitle prop usage, directly overlapping with the translation fix in this PR.

Suggested reviewers

• OtavioStasiak
• diegolmello

Poem

🐰 A browser's choice, now crystal clear,
No more translations to fear!
Types align, selections shine,
In-app links work by design! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: default browser setting' directly addresses the main change, referring to fixing the default browser functionality issue described in CORE-1732.
Linked Issues check	✅ Passed	The code changes implement both issues from CORE-1732: fixing the default browser setting behavior by using TType values for proper matching, and fixing i18n display by changing translateTitle from false to true.
Out of Scope Changes check	✅ Passed	All changes are scoped to DefaultBrowserView/index.tsx and directly address the linked issue requirements; no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

✅ Copyable Unit Test edits generated.

• Create PR with unit tests
• Commit unit tests in branch default-browser-fix
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Rohit3523]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Note

Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[coderabbitai]

Here are the copyable unit test edits:

Copyable Edits

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.69.0.108192

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQnZNMDTWcExHhSchnMlxBl-vv4Co-A_RvysQjHBXCb5SbpNQVgoKcDLLF1x63rypMIm6DPiF68j7LBiqGA

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.69.0.108193