-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(android): correct accessibility focus order in inverted FlatList #6934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughAdds Gradle dependency substitution to resolve React Native artifacts to the local React Native include build, and introduces inversion-aware accessibility handling in Android ReactScrollView with a setter and reversed accessibility child traversal for inverted virtualized lists. Changes
Sequence Diagram(s)sequenceDiagram
participant JS as JS Layer
participant Manager as ReactScrollViewManager
participant View as ReactScrollView (native)
participant AS as Accessibility Service
JS->>Manager: mount VirtualizedList (inverted)
Manager->>View: setIsInvertedVirtualizedList(true)
AS->>View: request accessibility children
View->>View: addChildrenForAccessibility(outChildren) -- reverse when inverted
View->>AS: return children in visual order
AS->>User: traverse items in visual order
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Android Build Available Rocket.Chat Experimental 4.69.0.108196 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTlK_aaCydNoR8tL0LU9ha91x4SUn6F8LQ_l7193fkFssxP1kKCqvtZvuPhoyE9s7WolKu01pF8dITARNJC |
Proposed changes
Issue(s)
https://rocketchat.atlassian.net/browse/MA-96
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.