Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jan 11, 2026

Important

Add searchable settings feature with SearchableSetting component, search input, and result highlighting in the webview UI.

  • Searchable Settings:
    • Introduce SearchableSetting component to wrap settings elements for search indexing.
    • Implement SettingsSearch component with input and results highlighting.
    • Add search functionality to SettingsView with tab navigation and result highlighting.
  • Components Updated:
    • Wrap settings in About.tsx, AutoApproveSettings.tsx, BrowserSettings.tsx, CheckpointSettings.tsx, ContextManagementSettings.tsx, ExperimentalSettings.tsx, LanguageSettings.tsx, NotificationSettings.tsx, PromptsSettings.tsx, SlashCommandsSettings.tsx, TerminalSettings.tsx, UISettings.tsx with SearchableSetting.
  • CSS:
    • Add settings-highlight-fade animation in index.css for search result highlighting.
  • Tests:
    • Update tests in SettingsView.spec.tsx and SettingsView.change-detection.spec.tsx to accommodate new search functionality.

This description was created by Ellipsis for 0e012f7. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners January 11, 2026 18:15
@mrubens mrubens marked this pull request as draft January 11, 2026 18:15
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. UI/UX UI/UX related or focused labels Jan 11, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 11, 2026

Rooviewer Clock   See task on Roo Cloud

All issues have been resolved. The code cleanly handles Escape key interactions and the search index registration approach has been refactored to use context-based registration. Latest test fixes add necessary mocks for the new search components.

  • Escape key handler unreachable when no results - users cannot close dropdown with Escape when "No results found" is displayed
  • Duplicate Escape key handler code at lines 77-82 is now unreachable dead code
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jan 11, 2026
mrubens and others added 2 commits January 11, 2026 14:05
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@mrubens mrubens changed the title Prototype of a simpler searchable settings Basic settings search Jan 11, 2026
@mrubens mrubens marked this pull request as ready for review January 11, 2026 19:15
@roomote
Copy link
Contributor

roomote bot commented Jan 11, 2026

Rooviewer Clock   See task on Roo Cloud

The search functionality implementation looks good overall. One cleanup item remains.

  • Escape key handler unreachable when no results - users cannot close dropdown with Escape when "No results found" is displayed
  • Duplicate Escape key handler code at lines 77-82 is unreachable dead code and should be removed

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens mrubens marked this pull request as draft January 11, 2026 19:20
@mrubens mrubens force-pushed the searchable_settings branch from d7bab8c to 0e012f7 Compare January 11, 2026 19:45
@mrubens mrubens marked this pull request as ready for review January 11, 2026 19:46
@roomote
Copy link
Contributor

roomote bot commented Jan 11, 2026

Rooviewer Clock   See task on Roo Cloud

All issues have been resolved. The code cleanly handles Escape key interactions and the search index registration approach has been refactored to use context-based registration. Latest test fixes add necessary mocks for the new search components.

  • Escape key handler unreachable when no results - users cannot close dropdown with Escape when "No results found" is displayed
  • Duplicate Escape key handler code at lines 77-82 is now unreachable dead code and should be removed

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens mrubens merged commit 632b86c into main Jan 11, 2026
17 checks passed
@mrubens mrubens deleted the searchable_settings branch January 11, 2026 19:57
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 11, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XXL This PR changes 1000+ lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants