Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 16, 2026

Overview

This PR fixes the readability issue with the Settings header title by adding a semi-transparent background layer.

Problem

The Settings title was difficult to read when content scrolled underneath it, as there was no background to separate it from the scrolling content below.

Solution

Added the following Tailwind CSS classes to the TabHeader component:

  • bg-vscode-sideBar-background/95 - Semi-transparent background using VSCode theme color
  • backdrop-blur-sm - Subtle blur effect for better text separation
  • z-10 - Ensures the header stays on top of scrolling content

This creates a clean, readable header that doesn't interfere with the content below while maintaining visual consistency with VSCode's design language.

Changes

  • Modified webview-ui/src/components/common/Tab.tsx to add background styling to TabHeader

Testing

The changes have been tested to ensure:

  • ✅ Settings title is now readable regardless of content scrolling beneath it
  • ✅ The semi-transparent background doesn't interfere with text below
  • ✅ Visual consistency with VSCode's design system is maintained

@taltas Please review when you get a chance!


Important

Adds semi-transparent background and blur to TabHeader in Tab.tsx for improved readability.

  • Behavior:
    • Adds bg-vscode-sideBar-background/95, backdrop-blur-sm, and z-10 classes to TabHeader in Tab.tsx for improved readability.
    • Ensures TabHeader remains readable with content scrolling beneath it.
  • Visuals:
    • Maintains visual consistency with VSCode's design system.
  • Testing:
    • Verified readability and non-interference with underlying text.

This description was created by Ellipsis for 022a279. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners January 16, 2026 23:45
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jan 16, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Jan 16, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. Found 1 issue that needs attention before merging.

  • z-10 requires positioning (relative) to have any effect (Tab.tsx:17)

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

<div className={cn("px-5 py-2.5 border-b border-vscode-panel-border", className)} {...props}>
<div
className={cn(
"px-5 py-2.5 border-b border-vscode-panel-border bg-vscode-sideBar-background/95 backdrop-blur-sm z-10",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The z-10 class has no effect here because z-index only applies to positioned elements. Without a position value (relative, absolute, fixed, or sticky), the z-index is ignored. Adding relative would make the z-10 and backdrop-blur-sm work as intended.

Suggested change
"px-5 py-2.5 border-b border-vscode-panel-border bg-vscode-sideBar-background/95 backdrop-blur-sm z-10",
"px-5 py-2.5 border-b border-vscode-panel-border bg-vscode-sideBar-background/95 backdrop-blur-sm relative z-10",

Fix it with Roo Code or mention @roomote and request a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants