feat: opus support via libopus and allow registering additional codecs#851
Open
aschey wants to merge 12 commits intoRustAudio:masterfrom
Open
feat: opus support via libopus and allow registering additional codecs#851aschey wants to merge 12 commits intoRustAudio:masterfrom
aschey wants to merge 12 commits intoRustAudio:masterfrom
Conversation
Signed-off-by: royalmustard <royalmustard@memium.de>
aschey
commented
Feb 22, 2026
| wasm-bindgen = ["cpal/wasm-bindgen"] | ||
|
|
||
| # Base symphonia feature (doesn't enable any codecs) | ||
| symphonia = ["dep:symphonia"] |
Contributor
Author
There was a problem hiding this comment.
Note that there are a lot of places that use #[cfg(feature = "symphonia")] even though there was no feature named symphonia. A feature with this name was created implicitly due to the other features that reference symphonia/xxx. For symphonia-libopus, I wanted to make sure the base symphonia feature was also enabled, so we need to make this feature explicit now.
4d34fa3 to
d73d0e8
Compare
d73d0e8 to
eda8f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #806
Resolves #38
Thanks @royalmustard for starting on this! I took the changes from the previous PR and made a few tweaks:
symphonia-libopusflag. Opus support is a common enough request that I think it makes sense to support this via a flag rather than require users to add the codec manually.