Open
Conversation
Open
Author
|
Okay, I found the underlying issue: For now, I will do like the |
Author
|
Opened up for review, since the All IEEE 1619-2018 tests passes, parallel computing is supported, and doc is done. |
Author
|
Made a rookie mistake, the GF operations are not constant time. This should be an easy fix |
Member
|
Right now I work on other things, so I will try to take a look at this in a week or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the trait on the
prerelease ofcipher.Suggestions for the
ciphercrate:ctscrate simply bypasses the trait system and implement the encryption methods directly on the struct.Missing:
ciphertraits correctly (cannot actually be done, see comment below)InOut-based methods, as I initially wrote the implementation in-place.If you've got any suggestion for the first point, it would be appreciated!