Skip to content

Php84 fix test warnings #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitbulk merged 2 commits into from
Jan 13, 2025
Merged

Php84 fix test warnings #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa7621e
Fix warnings found running php8.4 and PHPUnit 11.5.0
pitbulk Jan 11, 2025
7516681
cleanup: remove Travis CI references
pitbulk Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .coveralls.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
service_name: travis-ci
service_name: github

src_dir: lib
src_dir: src

coverage_clover: tests/build/logs/clover.xml

Expand Down
28 changes: 0 additions & 28 deletions .travis.yml
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions tests/src/OneLogin/Saml2/ResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,10 +1607,12 @@ public function testIsInValidCert()

$response = new Response($settings, $xml);

$this->assertFalse($response->isValid());
$this->assertFalse(@$response->isValid());

$possibleErrors = [
"openssl_x509_read(): supplied parameter cannot be coerced into an X509 certificate!",
"openssl_x509_read(): X.509 Certificate cannot be retrieved"
"openssl_x509_read(): X.509 Certificate cannot be retrieved",
"Unable to extract public key"
];
$this->assertTrue(in_array($response->getError(), $possibleErrors));
}
Expand Down
4 changes: 2 additions & 2 deletions tests/src/OneLogin/Saml2/SettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public function testThatOnlyBooleansCanBeUsedForCompressionSettings($invalidValu
$this->assertTrue($responsesIsInvalid);
}

public function invalidCompressSettingsProvider()
static public function invalidCompressSettingsProvider()
{
return array(
array(1),
Expand Down Expand Up @@ -539,7 +539,7 @@ public function testGetSPMetadataWithX509CertNew($alwaysIncludeEncryption, $want
$this->assertEquals($expectEncryptionKeyDescriptor ? 2 : 0, substr_count($metadata, '<md:KeyDescriptor use="encryption"'));
}

public function getSPMetadataWithX509CertNewDataProvider()
static public function getSPMetadataWithX509CertNewDataProvider()
{
return [
'settings do not require encryption' => [
Expand Down
Loading