Skip to content

Do not confuse Settings::getIdPSLOResponseUrl() with bad example #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RoSk0 wants to merge 2 commits into from
Closed

Do not confuse Settings::getIdPSLOResponseUrl() with bad example #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c02d465
Do not confuse Settings::getIdPSLOResponseUrl() with bad example
RoSk0 Jan 30, 2025
99c5d56
Improve IdP configuration validation
RoSk0 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions lib/Saml2/Settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,26 +543,19 @@ public function checkIdPSettings($settings)
$errors[] = 'idp_entityId_not_found';
}

if (!isset($idp['singleSignOnService'])
|| !isset($idp['singleSignOnService']['url'])
|| empty($idp['singleSignOnService']['url'])
) {
if (!isset($idp['singleSignOnService']['url'])) {
$errors[] = 'idp_sso_not_found';
} else if (!filter_var($idp['singleSignOnService']['url'], FILTER_VALIDATE_URL)) {
$errors[] = 'idp_sso_url_invalid';
}

if (isset($idp['singleLogoutService'])
&& isset($idp['singleLogoutService']['url'])
&& !empty($idp['singleLogoutService']['url'])
if (isset($idp['singleLogoutService']['url'])
&& !filter_var($idp['singleLogoutService']['url'], FILTER_VALIDATE_URL)
) {
$errors[] = 'idp_slo_url_invalid';
}

if (isset($idp['singleLogoutService'])
&& isset($idp['singleLogoutService']['responseUrl'])
&& !empty($idp['singleLogoutService']['responseUrl'])
if (isset($idp['singleLogoutService']['responseUrl'])
&& !filter_var($idp['singleLogoutService']['responseUrl'], FILTER_VALIDATE_URL)
) {
$errors[] = 'idp_slo_response_url_invalid';
Expand Down
2 changes: 1 addition & 1 deletion settings_example.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
'url' => '',
// URL location of the IdP where the SP will send the SLO Response (ResponseLocation)
// if not set, url for the SLO Request will be used
'responseUrl' => '',
// 'responseUrl' => '',
// SAML protocol binding to be used when returning the <Response>
// message. SAML Toolkit supports for this endpoint the
// HTTP-Redirect binding only
Expand Down
Loading