Fix build-system in pyproject.toml#341
Open
mgorny wants to merge 1 commit intoSAML-Toolkits:masterfrom
Open
Conversation
Fix the `build-system.requires` key to specify `poetry-core` rather than `poetry` as the correct package providing `poetry.core.*` backend. Remove `setuptools` and `wheel` requirements since they are not used when building via the PEP517 backend.
Contributor
|
As you can see in the CI, if I don't add it on build-system.requires, there is an strange issue where the error is raised, even if the setuptools was installed in the very beginning with the command |
Author
|
The problem is that you're running Python < 3.6. While poetry might support it still (I didn't check), pip does not, so it's installing some old version (i.e. the last version supporting Python 2.7/3.5) and that version is simply broken with PEP517 builds. |
Contributor
|
@mgorny Soon I plan to deprecate support on python 2.7, 3.4 and 3.5 on this toolkit (only security patch could be supported) so gonna be a good time to apply this PR and improve the code properly with new features available in python > 3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
build-system.requireskey to specifypoetry-corerather thanpoetryas the correct package providingpoetry.core.*backend. Removesetuptoolsandwheelrequirements since they are not used when building via the PEP517 backend.