Update authn_request.py

[HichamDz38]

Values can be 0,1 empty string etc when stored in the database or in data conversion it's not required to be True/False specifically

[HichamDz38]

i don't know why these tests fails, but i don't thing that its' because on the PR changes, might be it will fails with the actual code as it is as well

[pitbulk]

The possible values for requestedAuthnContext are True, False or a List. I have tests that check that those are the introduced values.

At the doc in the settings section you can read

// Authentication context.
// Set to false and no AuthContext will be sent in the AuthNRequest,
// Set true or don't present this parameter and you will get an AuthContext 'exact' 'urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport'
// Set an array with the possible auth context values: array ('urn:oasis:names:tc:SAML:2.0:ac:classes:Password', 'urn:oasis:names:tc:SAML:2.0:ac:classes:X509'),

Why don't you instead force conversion from DB to the toolkit?

Your suggested code fails as a list will pass the condition:

if security["requestedAuthnContext"]

[HichamDz38]

it's possible to do that in another way, by checking first if the security["requestedAuthnContext"] is a list by : isintance(security["requestedAuthnContext"],list),
it's a common for developers that True/False not required to be specifically/literally True or False it can be 0, 1 etc,
i can do that: checking if it's a list first and the tests will pass,
is that ok?

[pitbulk]

If you first check for the list, it should be ok

[HichamDz38]

@pitbulk , i did that already in the last commit,
however the tests still fails,
by the way i run the tests in the master branch, and lot of them fails

[HichamDz38]

@pitbulk , i am still waiting for your response,
is what i am proposing okey or i need to do any changes?
greetings