-
Notifications
You must be signed in to change notification settings - Fork 160
Demonstrate cds-feature-attachments with bookshop #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 51 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
35a59ed
Add dependency to cds-feature-attachments
mofterdinger 298d31b
Added UI facets with translations
mofterdinger 2e85b8b
fixed wrong target
mofterdinger 925bc98
added further texts
mofterdinger 02fc3d1
use version 1.0.3
mofterdinger 6dc93dc
minor fixes
mofterdinger 708dbfd
Update UI5 to version 1.129.0
mofterdinger d8964e5
Renamed attachmentsAndLinks to covers
mofterdinger 4bcc3e5
use snapshot again
mofterdinger c9a10a2
workaround for etag issue
mofterdinger b650ec1
revert to released version
mofterdinger 697ab0e
Merge branch 'main' into attachments
mofterdinger 68889d6
Revert to UI5 1.128.0 to fix etag issue.
mofterdinger 85c12f6
Downgrade to UI5 1.126.0
mofterdinger 8df1897
Merge branch 'main' into attachments
mofterdinger dca1976
Update UI5 to 1.126.2
mofterdinger cdcd3b2
fixed broken link in README.md
mofterdinger 95a2c87
for testing
mofterdinger bd0a970
disable etag for testing
mofterdinger 2b429b4
Use 1.0.4-SNAPSHOT
mofterdinger 651c17b
use Attachments from cds-feature-attachments-fs
mofterdinger d825673
revert to standard plugin
mofterdinger 0bf6369
revert changes
mofterdinger e2460ba
removed unused labels
mofterdinger 286d291
disable etag for testing
mofterdinger 77748bc
fixed model
mofterdinger d3f4316
Merge branch 'main' into attachments
mofterdinger c0d552f
enhanced logging
mofterdinger 7c48e06
use css annotations
mofterdinger e9ac89a
Use snapshot
mofterdinger 0df64a9
Bump cds-feature-attachments to 1.0.4
mofterdinger 749bbac
revert some logging changes
mofterdinger 1641d43
revert formatting change
mofterdinger def3609
Use 1.0.5-SNAPSHOT
mofterdinger 3f11505
use snapshot
mofterdinger d56fd14
Revert "Use 1.0.5-SNAPSHOT"
mofterdinger 74ef51b
Revert "use snapshot"
mofterdinger 091e3e8
enable etag on content field again and test with UI5 1.131 SNAPSHOT
mofterdinger a5d63fc
annotate up_ with UI.Hidden: true
mofterdinger 2bb8afc
use snapshot
mofterdinger 3a9c61b
Use cds-services 3.4.0
mofterdinger 08b4a7e
Merge branch 'main' into attachments
mofterdinger 231fed4
Update pom.xml
mofterdinger 87a18e7
Update pom.xml
mofterdinger c3f239f
Merge branch 'main' into attachments
mofterdinger 1defce9
increase app router timeout
mofterdinger ea54fb4
added binding to malware-scanner service
mofterdinger ad9be09
Removed malware scanner binding
mofterdinger 1d87f11
Use 1.0.5 of cds-feature-attachments
mofterdinger 0be1b6a
Merge branch 'main' into attachments
mofterdinger 3ee5197
Merge branch 'main' into attachments
mofterdinger ad56b54
Merge branch 'main' into attachments
mofterdinger 52c99df
Merge branch 'main' into attachments
mofterdinger 9f76602
review feedback
mofterdinger 04a3255
added comments
mofterdinger c9648c0
review feedback
mofterdinger da1cf22
added runtime scope
mofterdinger 7445a5e
review feedback
mofterdinger 5a6cd19
Merge branch 'main' into attachments
mofterdinger 9311fcd
Update SAP UI5 to 1.131.0
mofterdinger 2e09a49
added missing translations
mofterdinger 67c220f
moved administrative data to the bottom
mofterdinger 8a7e4fa
Cleanup translations
mofterdinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
mofterdinger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <artifactId>bookshop-parent</artifactId> | ||
| <groupId>my</groupId> | ||
| <version>${revision}</version> | ||
| </parent> | ||
|
|
||
| <artifactId>bookshop-db</artifactId> | ||
| <packaging>pom</packaging> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>com.sap.cds</groupId> | ||
| <artifactId>cds-maven-plugin</artifactId> | ||
| <version>${cds.services.version}</version> | ||
| <executions> | ||
| <execution> | ||
| <id>cds.clean</id> | ||
| <goals> | ||
| <goal>clean</goal> | ||
| </goals> | ||
| </execution> | ||
|
|
||
| <execution> | ||
| <id>cds.resolve</id> | ||
| <goals> | ||
| <goal>resolve</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.