Skip to content

Update cds-dk, plugins and Postgres #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mofterdinger merged 3 commits into from
Nov 13, 2024
+6 −6
Merged

Update cds-dk, plugins and Postgres #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
418d57d
Bump plugin and cds-dk
mofterdinger Nov 13, 2024
beb17fc
Bump Postgres to 16
mofterdinger Nov 13, 2024
e146177
Update SAP UI5 to latest LTS version
mofterdinger Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/fiori.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
};
</script>

<script id="sap-ushell-bootstrap" src="https://sapui5.hana.ondemand.com/1.120.11/test-resources/sap/ushell/bootstrap/sandbox.js"></script>
<script id="sap-ui-bootstrap" src="https://sapui5.hana.ondemand.com/1.120.11/resources/sap-ui-core.js"
<script id="sap-ushell-bootstrap" src="https://sapui5.hana.ondemand.com/1.120.23/test-resources/sap/ushell/bootstrap/sandbox.js"></script>
<script id="sap-ui-bootstrap" src="https://sapui5.hana.ondemand.com/1.120.23/resources/sap-ui-core.js"
data-sap-ui-libs="sap.m, sap.ushell, sap.collaboration, sap.ui.layout"
data-sap-ui-compatVersion="edge"
data-sap-ui-theme="sap_horizon"
Expand Down
2 changes: 1 addition & 1 deletion mta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ resources:
service: postgresql-db
service-plan: standard
config:
engine_version: "14"
engine_version: "16"
Copy link
Contributor

@vmikhailenko vmikhailenko Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to re-create test Postgres instance after that.

Copy link
Member Author

@mofterdinger mofterdinger Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that could be the case. Last time if I remember correct the instance was updated during deployment. We will see.

Copy link
Member Author

@mofterdinger mofterdinger Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, version 16 isn't available yet:

Service broker error: Service broker backing-services-broker-postgresql-db failed with: data/engine_version should be equal to one of the allowed values

Found also this documentation: https://help.sap.com/docs/postgresql-hyperscaler-option/postgresql-on-sap-btp-hyperscaler-option-c92112ee69784c3383a0fb8361156a6f/parameters

Yes, considering the allowed values of 12, 13, 14 and 15.
Note

Automatic in-place upgrades for major versions are not supported in Ali regions and for Azure SingleServer.

Copy link
Member Author

@mofterdinger mofterdinger Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will downgrade to 15 in a new PR.

multi_az: false

- name: cf-logging
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<spring.boot.version>3.3.5</spring.boot.version>
<cf-java-logging-support.version>3.8.4</cf-java-logging-support.version>

<cds.cdsdk-version>8.4.0</cds.cdsdk-version>
<cds.cdsdk-version>8.4.1</cds.cdsdk-version>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
Expand Down Expand Up @@ -78,7 +78,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.3.1</version>
<version>3.5.2</version>
<configuration>
<failIfNoTests>true</failIfNoTests>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion srv/src/main/resources/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
my.bookshop.postgresImage: postgres:14
my.bookshop.postgresImage: postgres:16

cds:
dataSource.csv:
Expand Down