Remove open endpoint /actuator/health #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermarc
approved these changes
Jan 9, 2025
Contributor
beckermarc
left a comment
beckermarc
left a comment
There was a problem hiding this comment.
Sounds reasonable. What is missing is showing HOW you would authenticate the /health endpoint correctly, e.g. for intregration into Availability Service. But that must not be part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, CAP Java provides the open endpoints
actuator/health/livenessandactuator/health/readiness. Both can be used by Cf or K8s for application health checks.There is no need for a public
actuator/healthanymore.See also in mta.yaml:
cloud-cap-samples-java/mta-multi-tenant.yaml
Line 18 in 228e05f