Skip to content

Conversation

@c-salomonsen
Copy link
Contributor

@c-salomonsen c-salomonsen commented Feb 24, 2025

This PR does a couple of things:

  1. Cleans up the directory structure and removes the docker directory which we dont really need.
  2. Uses a different approach to setting dependencies:
    • Instead of us manually having to ensure docker/requirements.txt is always up-to-date, use uvto sync with the currently used packages from pyproject.toml
    • But don't worry, no special commands inside the docker environment is needed. Just run python ... and everything should work, so no need to use uv inside container 😉
  3. Adds a workflow to push the container to the GitHub container repository ghcr.io instead of DockerHub, allowing us to tie the docker image up to the repository, and not a single user.

This change populates this repository's packages. Go to that link for info on how to pull.

TODO: Add instructions to README.md later

With this new update it will always ensure the newest packages from
pyproject.toml is used inside the container
@c-salomonsen c-salomonsen added the enhancement New feature or request label Feb 24, 2025
@c-salomonsen c-salomonsen self-assigned this Feb 24, 2025
@c-salomonsen c-salomonsen marked this pull request as ready for review February 24, 2025 19:36
Just had to have it there to test that it would work before pushing to
main :)
Copy link
Contributor

@Johanmkr Johanmkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow-guru has spoken, amen

@c-salomonsen
Copy link
Contributor Author

@Johanmkr Thou are thy blessed, child.

@c-salomonsen c-salomonsen merged commit 5a50a07 into main Feb 25, 2025
2 checks passed
@c-salomonsen c-salomonsen deleted the docker-prune branch February 25, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants