Skip to content

Conversation

@sot176
Copy link
Contributor

@sot176 sot176 commented Feb 4, 2025

Moved my metric test function into the test directory. Updated the load files with my classes. Updated the choices in the main file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I'll just add a quick remark that PR #31 changes the way we initialize our models from taking a in_channels: int to a input_shape: tuple[int, int, int], representing a single image with dimensions [channel, height, width].

I think it makes sense to accept your current model, then you can modify it later in PR #31 like Jan, I and soon Johan have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the reminder. I will change my model initialization and adjust it accordingly before merging

@c-salomonsen
Copy link
Contributor

Also you should try to format your code again with isort. e.g., isort format .

@sot176
Copy link
Contributor Author

sot176 commented Feb 4, 2025

I didn't know about isort but thanks for the tip I will format it properly.

@sot176
Copy link
Contributor Author

sot176 commented Feb 4, 2025

Now the files are properly formatted and the model is updated.

@c-salomonsen
Copy link
Contributor

Nice work!

@sot176 sot176 merged commit c455b8a into main Feb 4, 2025
4 checks passed
Seilmast pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants