Skip to content

Conversation

@hzavadil98
Copy link
Contributor

Merge me please

@Seilmast
Copy link
Collaborator

In PR #77 I've changed the getmetrics and resetmetric to not have the underscores as we talked about yesterday. If you could remove the underscores when you call the methods and push it to this branch I'll review + merge it.
Also, if you see this message, please merge #77

@hzavadil98
Copy link
Contributor Author

Thanks for letting me know @Seilmast, I believe it should be fine now.

Copy link
Collaborator

@Seilmast Seilmast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Seilmast Seilmast merged commit 1f740ce into main Feb 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants